From: Glen Choo <chooglen@google.com>
To: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18))
Date: Mon, 21 Nov 2022 14:22:56 -0800 [thread overview]
Message-ID: <kl6ltu2sdk1r.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <Y3g95OYdwzq2OP3z@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
> * ab/submodule-no-abspath (2022-11-09) 1 commit
> (merged to 'next' on 2022-11-18 at 34d0accc7b)
> + submodule--helper absorbgitdirs: no abspaths in "Migrating git..."
> (this branch is used by ab/remove--super-prefix.)
>
> Remove an absolute path in the "Migrating git directory" message.
>
> Will merge to 'master'.
> source: <patch-1.1-34b54fdd9bb-20221109T020347Z-avarab@gmail.com>
>
(Sorry, I should have spoken up before this got merged to 'next'.)
I have some reservations about this that I mentioned in [1], namely:
- Does this work correctly when using a worktree?
- If "absorbgitdirs" becomes consistent with other "git submodule"
subcommands and prints relative paths to submodules, then this
produces the wrong result.
We probably won't see any complaints about this for a while, since
submodules + worktrees are an uncommon combination, but I expect that
we'll have to revert this at some point.
[1] https://lore.kernel.org/git/kl6lmt8qv9gc.fsf@chooglen-macbookpro.roam.corp.google.com
next prev parent reply other threads:[~2022-11-21 22:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 2:22 What's cooking in git.git (Nov 2022, #04; Fri, 18) Taylor Blau
2022-11-20 11:24 ` SZEDER Gábor
2022-11-20 17:42 ` Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18)) Philip Oakley
2022-11-21 0:37 ` Junio C Hamano
2022-11-21 18:10 ` Philip Oakley
2022-11-20 19:46 ` What's cooking in git.git (Nov 2022, #04; Fri, 18) Phillip Wood
2022-11-20 21:24 ` Johannes Schindelin
2022-11-21 0:47 ` Junio C Hamano
2022-11-21 1:00 ` Taylor Blau
2022-11-22 14:58 ` Phillip Wood
2022-11-20 21:45 ` Junio C Hamano
2022-11-20 23:51 ` Taylor Blau
2022-11-20 23:24 ` Junio C Hamano
2022-11-20 23:52 ` Taylor Blau
2022-11-21 3:36 ` Junio C Hamano
2022-11-22 22:56 ` Taylor Blau
2022-11-21 0:10 ` Junio C Hamano
2022-11-21 0:16 ` Taylor Blau
2022-11-23 0:03 ` Junio C Hamano
2022-11-21 22:22 ` Glen Choo [this message]
2022-11-22 22:45 ` [PATCH] submodule absorbgitdirs: use relative <from> and <to> paths Ævar Arnfjörð Bjarmason
2022-11-23 0:43 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl6ltu2sdk1r.fsf@chooglen-macbookpro.roam.corp.google.com \
--to=chooglen@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).