From: Philip Oakley <philipoakley@iee.email>
To: git@vger.kernel.org
Cc: Taylor Blau <me@ttaylorr.com>
Subject: Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18))
Date: Sun, 20 Nov 2022 17:42:43 +0000 [thread overview]
Message-ID: <8791cb85-cf4a-4302-5c1a-54a7e7766cfb@iee.email> (raw)
In-Reply-To: <Y3g95OYdwzq2OP3z@nand.local>
Ping, Hopefully an easy single patch review for someone on-list.
Patch [v4] itself:
https://lore.kernel.org/git/20221112143616.1429-1-philipoakley@iee.email/
Available at: https://github.com/ttaylorr/git/tree/po/pretty-hard-trunc
On 19/11/2022 02:22, Taylor Blau wrote:
> --------------------------------------------------
> [Cooking]
>
> * po/pretty-hard-trunc (2022-11-13) 1 commit
> - pretty-formats: add hard truncation, without ellipsis, options
>
> Add a new pretty format which truncates without ellipsis.
>
> Waiting for review.
> source: <20221112143616.1429-1-philipoakley@iee.email>
Potential review points:
Is the commit message sufficient?
Are the tests: Sufficient, Complete, Correct ?
Is `qz_to_tab_space` conversion applied correctly?
--
Philip
next prev parent reply other threads:[~2022-11-20 17:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 2:22 What's cooking in git.git (Nov 2022, #04; Fri, 18) Taylor Blau
2022-11-20 11:24 ` SZEDER Gábor
2022-11-20 17:42 ` Philip Oakley [this message]
2022-11-21 0:37 ` Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18)) Junio C Hamano
2022-11-21 18:10 ` Philip Oakley
2022-11-20 19:46 ` What's cooking in git.git (Nov 2022, #04; Fri, 18) Phillip Wood
2022-11-20 21:24 ` Johannes Schindelin
2022-11-21 0:47 ` Junio C Hamano
2022-11-21 1:00 ` Taylor Blau
2022-11-22 14:58 ` Phillip Wood
2022-11-20 21:45 ` Junio C Hamano
2022-11-20 23:51 ` Taylor Blau
2022-11-20 23:24 ` Junio C Hamano
2022-11-20 23:52 ` Taylor Blau
2022-11-21 3:36 ` Junio C Hamano
2022-11-22 22:56 ` Taylor Blau
2022-11-21 0:10 ` Junio C Hamano
2022-11-21 0:16 ` Taylor Blau
2022-11-23 0:03 ` Junio C Hamano
2022-11-21 22:22 ` ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18)) Glen Choo
2022-11-22 22:45 ` [PATCH] submodule absorbgitdirs: use relative <from> and <to> paths Ævar Arnfjörð Bjarmason
2022-11-23 0:43 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8791cb85-cf4a-4302-5c1a-54a7e7766cfb@iee.email \
--to=philipoakley@iee.email \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).