git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Glen Choo <chooglen@google.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jeff King" <peff@peff.net>
Subject: gc/resolve-alternate-symlinks (Re: What's cooking in git.git (Nov 2022, #05; Tue, 22))
Date: Tue, 22 Nov 2022 11:01:30 -0800	[thread overview]
Message-ID: <kl6lk03merud.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <xmqqfseargo4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> * gc/resolve-alternate-symlinks (2022-11-22) 1 commit
>  - object-file: use real paths when adding alternates
>
>  Resolve symbolic links when processing the locations of alternate
>  object stores, since failing to do so can lead to confusing and buggy
>  behavior.
>
>  Will merge to 'next'.
>  source: <pull.1382.v2.git.git.1669074557348.gitgitgadget@gmail.com>

I plan to do another reroll based off Ævar's feedback (thanks!), let's
hold off on merging until then?

Separately, I'd also prefer to hear from Peff regarding my reading of
37a95862c6 (alternates: re-allow relative paths from environment,
2016-11-07) and whether we want to continue 'supporting' broken paths in
the environment. I doubt it, but since he initially suggested it in his
fixup patch [1], his opinon would be reassuring :)

[1] https://lore.kernel.org/git/Y3aBzbzub7flQyca@coredump.intra.peff.net/

  reply	other threads:[~2022-11-22 19:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 18:24 What's cooking in git.git (Nov 2022, #05; Tue, 22) Junio C Hamano
2022-11-22 19:01 ` Glen Choo [this message]
2022-11-22 19:53   ` gc/resolve-alternate-symlinks (Re: What's cooking in git.git (Nov 2022, #05; Tue, 22)) Jeff King
2022-11-22 23:06 ` ab/remove--super-prefix & ab/submodule-no-abspath (was: " Ævar Arnfjörð Bjarmason
2022-11-23  2:19   ` ab/remove--super-prefix & ab/submodule-no-abspath Junio C Hamano
2022-11-22 23:35 ` What's cooking in git.git (Nov 2022, #05; Tue, 22) Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kl6lk03merud.fsf@chooglen-macbookpro.roam.corp.google.com \
    --to=chooglen@google.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).