git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Glen Choo <chooglen@google.com>
Subject: Re: ab/remove--super-prefix & ab/submodule-no-abspath
Date: Wed, 23 Nov 2022 11:19:08 +0900	[thread overview]
Message-ID: <xmqqleo2o1k3.fsf@gitster.g> (raw)
In-Reply-To: <221123.86edtua8i6.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 23 Nov 2022 00:06:09 +0100")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> * ab/submodule-no-abspath (2022-11-09) 1 commit
>>   (merged to 'next' on 2022-11-18 at 34d0accc7b)
>>  + submodule--helper absorbgitdirs: no abspaths in "Migrating git..."
>>  (this branch is used by ab/remove--super-prefix.)
>>
>>  Remove an absolute path in the "Migrating git directory" message.
>>
>>  Will merge to 'master'.
>>  source: <patch-1.1-34b54fdd9bb-20221109T020347Z-avarab@gmail.com>
>
> Glen pointed out an issue in ab/submodule-no-abspath which I just
> submitted a fix-on-top for in [1].

I'll queue that and keep the result in 'next' in the meantime, but
given that this seems to induce additional conflicts and who knows
what else is broken in it, I am not sure if it is a good use of our
time to even worry about "fixing" it.  What upside does it have with
the patch, other than the "Migrating git" message, which does not
even look like an improvement, at least to me?

> There will be a merge conflict with ab/remove--super-prefix, but one
> which I tried to make easy to resolve when crafting [1]. The resolution
> is:

... not something we would want to even worry about during -rc period.

Thanks.

  reply	other threads:[~2022-11-23  2:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 18:24 What's cooking in git.git (Nov 2022, #05; Tue, 22) Junio C Hamano
2022-11-22 19:01 ` gc/resolve-alternate-symlinks (Re: What's cooking in git.git (Nov 2022, #05; Tue, 22)) Glen Choo
2022-11-22 19:53   ` Jeff King
2022-11-22 23:06 ` ab/remove--super-prefix & ab/submodule-no-abspath (was: " Ævar Arnfjörð Bjarmason
2022-11-23  2:19   ` Junio C Hamano [this message]
2022-11-22 23:35 ` What's cooking in git.git (Nov 2022, #05; Tue, 22) Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqleo2o1k3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=chooglen@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).