From: Glen Choo <chooglen@google.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: ab/config-multi-and-nonbool (was Re: What's cooking in git.git (Feb 2023, #04; Wed, 22))
Date: Thu, 23 Feb 2023 13:10:35 -0800 [thread overview]
Message-ID: <kl6lfsaw84vo.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <xmqqbkllaxd7.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> * ab/config-multi-and-nonbool (2023-02-07) 10 commits
> - for-each-repo: with bad config, don't conflate <path> and <cmd>
> - config API: add "string" version of *_value_multi(), fix segfaults
> - config API users: test for *_get_value_multi() segfaults
> - for-each-repo: error on bad --config
> - config API: don't lose the git_*get*() return values
> - config API: have *_multi() return an "int" and take a "dest"
> - versioncmp.c: refactor config reading next commit
> - config API: add and use a "git_config_get()" family of functions
> - config tests: add "NULL" tests for *_get_value_multi()
> - config tests: cover blind spots in git_die_config() tests
>
> Assorted config API updates.
>
> Will merge to 'next'?
> source: <cover-v5-00.10-00000000000-20230207T154000Z-avarab@gmail.com>
I would prefer to eject 06/10 [1] for now and leave it in for a future
cleanup series. I haven't confirmed whether it's safe (the practical
effect of that patch is that the *_get() functions can now return -1
instead of 1, so the patch is safe if all callers only check if the
return value is zero, and not whether it has a particular sign), and I
don't think 06/10 is absolutely necessary to the series.
But if we are already quite convinced that this is safe, I have no
objections to merging it as-is.
[1] https://lore.kernel.org/git/patch-v5-06.10-b515ff13f9b-20230207T154000Z-avarab@gmail.com
next prev parent reply other threads:[~2023-02-23 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 3:12 What's cooking in git.git (Feb 2023, #04; Wed, 22) Junio C Hamano
2023-02-23 5:51 ` mc/credential-helper-www-authenticate (Re: What's cooking in git.git (Feb 2023, #04; Wed, 22)) Victoria Dye
2023-02-23 9:48 ` Jeff King
2023-02-27 17:19 ` Matthew John Cheetham
2023-02-23 21:10 ` Glen Choo [this message]
2023-02-23 22:57 ` ab/config-multi-and-nonbool (was " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl6lfsaw84vo.fsf@chooglen-macbookpro.roam.corp.google.com \
--to=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).