From: Jeff King <peff@peff.net>
To: Victoria Dye <vdye@github.com>
Cc: Matthew John Cheetham <mjcheetham@outlook.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: mc/credential-helper-www-authenticate (Re: What's cooking in git.git (Feb 2023, #04; Wed, 22))
Date: Thu, 23 Feb 2023 04:48:37 -0500 [thread overview]
Message-ID: <Y/c2dQTohGsN+3Me@coredump.intra.peff.net> (raw)
In-Reply-To: <3ab86863-fa15-a5c5-08c8-73ad775e04c8@github.com>
On Wed, Feb 22, 2023 at 09:51:28PM -0800, Victoria Dye wrote:
> Junio C Hamano wrote:
> > * mc/credential-helper-www-authenticate (2023-02-16) 3 commits
> > - credential: add WWW-Authenticate header to cred requests
> > - http: read HTTP WWW-Authenticate response headers
> > - t5563: add tests for basic and anoymous HTTP access
> >
> > Allow information carried on the WWW-AUthenticate header to be
> > passed to the credential helpers.
> >
> > Will merge to 'next'?
> > source: <pull.1352.v10.git.1676586881.gitgitgadget@gmail.com>
>
> Aside from some relatively minor touch-ups, this has been fairly stable
> since v8. I'm happy with it at this point, but I'm also curious to hear
> Peff's thoughts (since it was his review that prompted the switch to Apache
> for the test helper, among other changes).
I just gave v10 a careful read. It looks quite nice to me, though there
were a few tiny nits that I think are worth a re-roll (the most
important being the strcasecmp buffer over-read).
-Peff
next prev parent reply other threads:[~2023-02-23 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 3:12 What's cooking in git.git (Feb 2023, #04; Wed, 22) Junio C Hamano
2023-02-23 5:51 ` mc/credential-helper-www-authenticate (Re: What's cooking in git.git (Feb 2023, #04; Wed, 22)) Victoria Dye
2023-02-23 9:48 ` Jeff King [this message]
2023-02-27 17:19 ` Matthew John Cheetham
2023-02-23 21:10 ` ab/config-multi-and-nonbool (was " Glen Choo
2023-02-23 22:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/c2dQTohGsN+3Me@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mjcheetham@outlook.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).