git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt
@ 2021-02-18  0:11 Joey Salazar
  2021-02-18  3:49 ` Denton Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Joey Salazar @ 2021-02-18  0:11 UTC (permalink / raw)
  To: Denton Liu, git@vger.kernel.org

Git Protocol version 2[1] defines 0002 as a Message Packet that indicates
the end of a response for stateless connections.

Change the naming of the 0002 Packet to 'Response End' to match the
parsing introduced in Wireshark's MR !1922 for consistency. A subsequent
MR in Wireshark will address additional mismatches.

[1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html
[2] gitlab.com/wireshark/wireshark/-/merge_requests/1922

Signed-off-by: Joey Salazar <jgsal@protonmail.com>
---
 Documentation/technical/protocol-v2.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt
index e597b74da39..fc163ca605c 100644
--- a/Documentation/technical/protocol-v2.txt
+++ b/Documentation/technical/protocol-v2.txt
@@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:

   * '0000' Flush Packet (flush-pkt) - indicates the end of a message
   * '0001' Delimiter Packet (delim-pkt) - separates sections of a message
-  * '0002' Message Packet (response-end-pkt) - indicates the end of a response
-    for stateless connections
+  * '0002' Response End Packet (response-end-pkt) - indicates the end of a
+    response for stateless connections

 Initial Client Request
 ----------------------
--
2.29.0.rc2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt
  2021-02-18  0:11 [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt Joey Salazar
@ 2021-02-18  3:49 ` Denton Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Denton Liu @ 2021-02-18  3:49 UTC (permalink / raw)
  To: Joey Salazar; +Cc: git@vger.kernel.org

On Thu, Feb 18, 2021 at 12:11:22AM +0000, Joey Salazar wrote:
> Git Protocol version 2[1] defines 0002 as a Message Packet that indicates
> the end of a response for stateless connections.
> 
> Change the naming of the 0002 Packet to 'Response End' to match the
> parsing introduced in Wireshark's MR !1922 for consistency. A subsequent
> MR in Wireshark will address additional mismatches.
> 
> [1] kernel.org/pub/software/scm/git/docs/technical/protocol-v2.html
> [2] gitlab.com/wireshark/wireshark/-/merge_requests/1922
> 
> Signed-off-by: Joey Salazar <jgsal@protonmail.com>

Reviewed-by: Denton Liu <liu.denton@gmail.com>

> ---
>  Documentation/technical/protocol-v2.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/technical/protocol-v2.txt b/Documentation/technical/protocol-v2.txt
> index e597b74da39..fc163ca605c 100644
> --- a/Documentation/technical/protocol-v2.txt
> +++ b/Documentation/technical/protocol-v2.txt
> @@ -33,8 +33,8 @@ In protocol v2 these special packets will have the following semantics:
> 
>    * '0000' Flush Packet (flush-pkt) - indicates the end of a message
>    * '0001' Delimiter Packet (delim-pkt) - separates sections of a message
> -  * '0002' Message Packet (response-end-pkt) - indicates the end of a response
> -    for stateless connections
> +  * '0002' Response End Packet (response-end-pkt) - indicates the end of a
> +    response for stateless connections
> 
>  Initial Client Request
>  ----------------------
> --
> 2.29.0.rc2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-18  3:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18  0:11 [OUTREACHY][PATCH v2] doc: fix naming of response-end-pkt Joey Salazar
2021-02-18  3:49 ` Denton Liu

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).