From: Brandon Casey <casey@nrlssc.navy.mil>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 7/8] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH
Date: Mon, 08 Jun 2009 18:39:40 -0500 [thread overview]
Message-ID: <fzqJj0x9YB8Uli2Fx2vePY55fbueEEY-IiruKI-uLEgS08KF5M8miw@cipher.nrlssc.navy.mil> (raw)
In-Reply-To: <20090608221117.GC29942@sigill.intra.peff.net>
I never received the referenced email. I'll try to extract from gmane
and test.
-brandon
Jeff King wrote:
> On Mon, Jun 08, 2009 at 09:41:49AM -0700, Junio C Hamano wrote:
>
>> We could further uglify the patch like this.
>> [...]
>> +git_broken_path_fix () {
>> + case ":$PATH:" in
>> + *:$1:*) : ok ;;
>> + *)
>> + PATH=$(
>> + SANE_TOOL_PATH="$1"
>> + IFS=: path= sep=
>> + set x $PATH
>> + shift
>> + for elem
>> + do
>> + case "$SANE_TOOL_PATH:$elem" in
>> + (?*:/bin | ?*:/usr/bin)
>> + path="$path$sep$SANE_TOOL_PATH"
>> + sep=:
>> + SANE_TOOL_PATH=
>> + esac
>> + path="$path$sep$elem"
>> + sep=:
>> + done
>> + echo "$path"
>> + )
>> + ;;
>> + esac
>> +}
>
> Wow. That _is_ ugly, but it actually addresses exactly both my concern
> and Brandon's. I kind of like it.
>
> -Peff
next prev parent reply other threads:[~2009-06-08 23:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7vk53vlxhz.fsf@alter.siamese.dyndns.org>
2009-06-05 23:36 ` [PATCH 0/8] enhancing builds on Solaris Brandon Casey
2009-06-05 23:36 ` [PATCH 1/8] Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall Brandon Casey
2009-06-05 23:36 ` [PATCH 2/8] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Brandon Casey
2009-06-05 23:36 ` [PATCH 3/8] diff-delta.c: "diff.h" is not a required include Brandon Casey
2009-06-05 23:36 ` [PATCH 4/8] On Solaris choose the OLD_ICONV iconv() declaration based on the UNIX spec Brandon Casey
2009-06-05 23:36 ` [PATCH 5/8] git-compat-util.h: tweak the way _XOPEN_SOURCE is set on Solaris Brandon Casey
2009-06-05 23:36 ` [PATCH 6/8] Makefile: define __sun__ on SunOS Brandon Casey
2009-06-05 23:36 ` [PATCH 7/8] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH Brandon Casey
2009-06-05 23:36 ` [PATCH 8/8] Makefile: add section for SunOS 5.7 Brandon Casey
2009-06-08 11:43 ` [PATCH 7/8] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH Jeff King
2009-06-08 13:39 ` Brandon Casey
2009-06-08 13:50 ` Jeff King
2009-06-08 15:59 ` Brandon Casey
2009-06-08 16:41 ` Junio C Hamano
2009-06-08 22:11 ` Jeff King
2009-06-08 23:39 ` Brandon Casey [this message]
2009-06-09 16:31 ` Brandon Casey
2009-06-06 0:47 ` [PATCH v2 3/8] diff-delta.c: "delta.h" is not a required include Brandon Casey
2009-06-06 1:21 ` Nicolas Pitre
2009-06-06 2:49 ` Brandon Casey
2009-06-06 3:10 ` Nicolas Pitre
2009-06-06 3:56 ` Brandon Casey
2009-06-08 23:53 ` [PATCH] git-compat-util.h: avoid using c99 flex array feature with Sun compiler 5.8 Brandon Casey
2009-06-06 7:29 ` [PATCH 2/8] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Jakub Narebski
2009-06-07 1:02 ` Brandon Casey
2009-06-07 5:40 ` [PATCH] configure: test whether -lresolv is needed Ralf Wildenhues
2009-06-05 23:46 ` [PATCH 0/8] enhancing builds on Solaris Brandon Casey
2009-06-06 0:13 ` Junio C Hamano
2009-06-06 0:41 ` Brandon Casey
2009-06-08 11:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fzqJj0x9YB8Uli2Fx2vePY55fbueEEY-IiruKI-uLEgS08KF5M8miw@cipher.nrlssc.navy.mil \
--to=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).