From: Brandon Casey <drafnel@gmail.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
gitster@pobox.com, git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH v2 3/8] diff-delta.c: "delta.h" is not a required include
Date: Fri, 5 Jun 2009 22:56:20 -0500 [thread overview]
Message-ID: <ee63ef30906052056le082bffrec078981dddaa013@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0906052302550.3906@xanadu.home>
On Fri, Jun 5, 2009 at 10:10 PM, Nicolas Pitre<nico@cam.org> wrote:
> On Fri, 5 Jun 2009, Brandon Casey wrote:
>
>> Nicolas Pitre wrote:
>> > On Fri, 5 Jun 2009, Brandon Casey wrote:
>> >
>> >> From: Brandon Casey <drafnel@gmail.com>
>> >>
>> >> When compiling diff-delta.c with the SUNWspro C99 compiler, it complains
>> >>
>> >> "diff-delta.c", line 314: identifier redeclared: create_delta
>> >>
>> >> There is nothing in "delta.h" that is required by diff-delta.c, so don't
>> >> include it.
>> >>
>> >> Signed-off-by: Brandon Casey <drafnel@gmail.com>
>> >
>> > NAK.
>> >
>> > This is common practice to include the header file declaring function
>> > prototypes into the file defining the actual function so to make sure
>> > the declaration matches with the definition. Deleting that include is
>> > actively ignoring a problem instead of fixing the cause of it.
>>
>>
>> It doesn't seem to like the structure being redeclared with a flex array
>> member and being passed as a const argument.
>>
>>
>> # cat > test.c <<EOF
>>
>> struct a_struct;
>>
>> extern void *test_func(const struct a_struct *f);
>>
>> struct a_struct {
>> int a;
>> int b;
>> char* c[];
>> };
>>
>> void *test_func(const struct a_struct *f)
>> {
>> return 0;
>> }
>> EOF
>>
>> # /opt/SUNWspro/bin/c99 -c test.c
>> "test.c", line 13: identifier redeclared: test_func
>> current : function(pointer to const struct a_struct {int a, int b, array[-1] of pointer to char c}) returning pointer to void
>> previous: function(pointer to const struct a_struct {int a, int b, array[-1] of pointer to char c}) returning pointer to void : "test.c", line 4
>> c99: acomp failed for test.c
>>
>>
>> If either the flex array is removed from the structure, or const is removed from
>> test_func argument, test.c will compile. Compiling with -O0 doesn't help.
>
> What if you define FLEX_ARRAY to 1, or even 0?
I tried that with my test.c example and '1' works, but not '0'. I'll
try setting FLEX_ARRAY to 1 and running git's test suite on Monday.
> If neither of those work then I'd simply remove the const. Generated
> code should be exactly the same with gcc. There is no const with
> sizeof_delta_index() which is already inconsistent.
>
> Kind of weird nevertheless.
Yes.
-brandon
next prev parent reply other threads:[~2009-06-06 3:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7vk53vlxhz.fsf@alter.siamese.dyndns.org>
2009-06-05 23:36 ` [PATCH 0/8] enhancing builds on Solaris Brandon Casey
2009-06-05 23:36 ` [PATCH 1/8] Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall Brandon Casey
2009-06-05 23:36 ` [PATCH 2/8] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Brandon Casey
2009-06-05 23:36 ` [PATCH 3/8] diff-delta.c: "diff.h" is not a required include Brandon Casey
2009-06-05 23:36 ` [PATCH 4/8] On Solaris choose the OLD_ICONV iconv() declaration based on the UNIX spec Brandon Casey
2009-06-05 23:36 ` [PATCH 5/8] git-compat-util.h: tweak the way _XOPEN_SOURCE is set on Solaris Brandon Casey
2009-06-05 23:36 ` [PATCH 6/8] Makefile: define __sun__ on SunOS Brandon Casey
2009-06-05 23:36 ` [PATCH 7/8] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH Brandon Casey
2009-06-05 23:36 ` [PATCH 8/8] Makefile: add section for SunOS 5.7 Brandon Casey
2009-06-08 11:43 ` [PATCH 7/8] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH Jeff King
2009-06-08 13:39 ` Brandon Casey
2009-06-08 13:50 ` Jeff King
2009-06-08 15:59 ` Brandon Casey
2009-06-08 16:41 ` Junio C Hamano
2009-06-08 22:11 ` Jeff King
2009-06-08 23:39 ` Brandon Casey
2009-06-09 16:31 ` Brandon Casey
2009-06-06 0:47 ` [PATCH v2 3/8] diff-delta.c: "delta.h" is not a required include Brandon Casey
2009-06-06 1:21 ` Nicolas Pitre
2009-06-06 2:49 ` Brandon Casey
2009-06-06 3:10 ` Nicolas Pitre
2009-06-06 3:56 ` Brandon Casey [this message]
2009-06-08 23:53 ` [PATCH] git-compat-util.h: avoid using c99 flex array feature with Sun compiler 5.8 Brandon Casey
2009-06-06 7:29 ` [PATCH 2/8] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments Jakub Narebski
2009-06-07 1:02 ` Brandon Casey
2009-06-07 5:40 ` [PATCH] configure: test whether -lresolv is needed Ralf Wildenhues
2009-06-05 23:46 ` [PATCH 0/8] enhancing builds on Solaris Brandon Casey
2009-06-06 0:13 ` Junio C Hamano
2009-06-06 0:41 ` Brandon Casey
2009-06-08 11:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee63ef30906052056le082bffrec078981dddaa013@mail.gmail.com \
--to=drafnel@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).