From: Philippe Blain <levraiphilippeblain@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Brandon Williams" <bwilliamseng@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Ryan Zoeller" <rtzoeller@rtzoeller.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH] parse-options: don't complete option aliases by default
Date: Thu, 15 Jul 2021 21:28:16 -0400 [thread overview]
Message-ID: <f85969ca-48e0-b2f1-6a42-7e4cc41a3639@gmail.com> (raw)
In-Reply-To: <xmqqy2a7s8vh.fsf@gitster.g>
Hi Junio,
Le 2021-07-15 à 14:57, Junio C Hamano a écrit :
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> I'm a bit biased here since I like --recursive better, but let's not
>> drag that whole argument up again. I don't find the argument in
>> bb62e0a99fc (clone: teach --recurse-submodules to optionally take a
>> pathspec, 2017-03-17) convincing enough to have moved such a prominent
>> use-case to a longer option name.
>
> I do agree that it is a separate topic to pick one or the other as
> the primary. I think this change means that the users no longer
> need to stop after hitting a tab:
>
> clone --recurs<TAB>
>
> and instead get to "clone --recurse-submodules" right away, which is
> a positigve change.
This is indeed the goal, I'll update the commit message to make that
clearer.
Of course, if the separate topic swaps which is
> the canonical and which is the alias, the same user would get the
> new canonical one right away from the same state.
>
> So it does look like a good change to me.
>
Thanks,
Philippe.
next prev parent reply other threads:[~2021-07-16 1:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 12:58 [PATCH] parse-options: don't complete option aliases by default Philippe Blain via GitGitGadget
2021-07-15 16:16 ` Ævar Arnfjörð Bjarmason
2021-07-15 17:16 ` Felipe Contreras
2021-07-15 18:57 ` Junio C Hamano
2021-07-16 1:28 ` Philippe Blain [this message]
2021-07-16 1:31 ` Philippe Blain
2021-07-15 17:04 ` Felipe Contreras
2021-07-16 1:28 ` Philippe Blain
2021-07-16 1:55 ` [PATCH v2] " Philippe Blain via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85969ca-48e0-b2f1-6a42-7e4cc41a3639@gmail.com \
--to=levraiphilippeblain@gmail.com \
--cc=avarab@gmail.com \
--cc=bwilliamseng@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=rtzoeller@rtzoeller.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).