git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>,
	Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Brandon Williams" <bwilliamseng@gmail.com>,
	"Ryan Zoeller" <rtzoeller@rtzoeller.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH] parse-options: don't complete option aliases by default
Date: Thu, 15 Jul 2021 21:28:00 -0400	[thread overview]
Message-ID: <c8322c37-38da-bde7-9361-adb68834b7d1@gmail.com> (raw)
In-Reply-To: <60f06a8a8e611_4b68208a9@natae.notmuch>

Hi Felipe,

Le 2021-07-15 à 13:04, Felipe Contreras a écrit :
> Philippe Blain via GitGitGadget wrote:
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>>
>> Helpfully, since 64cc539fd2 (parse-options: don't leak alias help
>> messages, 2021-03-21) these copies have the PARSE_OPT_FROM_ALIAS flag
>> set, so check that flag early in 'show_gitcomp' and do not print them,
> 
> Makes sense but I don't think what the patch is doing should be buried
> here. I think a separate paragraph explaining what you are trying to do
> will be better.

Indeed. Will clarify.


> 
> I agree this is better, and the patch itself looks obviously correct.
> 
> Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
> 

Thanks!

Philippe.

  reply	other threads:[~2021-07-16  1:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 12:58 [PATCH] parse-options: don't complete option aliases by default Philippe Blain via GitGitGadget
2021-07-15 16:16 ` Ævar Arnfjörð Bjarmason
2021-07-15 17:16   ` Felipe Contreras
2021-07-15 18:57   ` Junio C Hamano
2021-07-16  1:28     ` Philippe Blain
2021-07-16  1:31   ` Philippe Blain
2021-07-15 17:04 ` Felipe Contreras
2021-07-16  1:28   ` Philippe Blain [this message]
2021-07-16  1:55 ` [PATCH v2] " Philippe Blain via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8322c37-38da-bde7-9361-adb68834b7d1@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=bwilliamseng@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=rtzoeller@rtzoeller.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).