From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, larsxschneider@gmail.com
Subject: Re: [PATCH/RFC 1/1] t0027: Some tests are not expensive
Date: Mon, 1 May 2017 06:52:03 +0200 [thread overview]
Message-ID: <f79dd912-f798-7fa3-e8d0-cf90aef53bd5@web.de> (raw)
In-Reply-To: <xmqqfugpi8bk.fsf@gitster.mtv.corp.google.com>
On 01/05/17 05:07, Junio C Hamano wrote:
> tboegi@web.de writes:
>
>> From: Torsten Bögershausen <tboegi@web.de>
>> ...
>> The execution time for the non-expansive part is 6..8 seconds under Linux,
>> and 32 seconds under Mac Os X.
>>
>> Running the "expensive" version roughly doubles the time.
>
> Hmph, perhaps none of these is truly expensive if that is the case?
> I am not talking about ~10 or ~30 seconds in absolute terms, but
> reacting to "excluding the ones only halves the time."
>
> The files used in the test vector seem to be all small.
> Is the expensiveness due to the fact that there are so many of them,
Yes
> and not due to some specific conversion being very slow?
Yes
The easiest solution is probably to simply remove the EXPENSIVE
precondition from t0027 and run it always on all platforms.
At the same time t0025 can be removed.
Unless somebody objects, I will send a V2 the next days.
next prev parent reply other threads:[~2017-05-01 4:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <461E433C-DC8E-42FE-9B23-4A76BEFE0D11@gmail.com>
2017-04-24 17:00 ` t0025 flaky on OSX Torsten Bögershausen
2017-04-24 19:48 ` Torsten Bögershausen
2017-04-25 17:42 ` Lars Schneider
2017-04-26 4:12 ` Torsten Bögershausen
2017-04-26 19:41 ` Lars Schneider
2017-04-29 15:34 ` [PATCH/RFC 1/1] t0027: Some tests are not expensive tboegi
2017-05-01 3:07 ` Junio C Hamano
2017-05-01 4:52 ` Torsten Bögershausen [this message]
2017-05-02 15:56 ` [PATCH v2 1/1] t0027: tests are not expensive; remove t0025 tboegi
2017-05-02 16:11 ` Johannes Schindelin
2017-05-09 1:29 ` Junio C Hamano
2017-05-09 4:12 ` Torsten Bögershausen
2017-05-10 14:06 ` [PATCH v3 " tboegi
2017-05-10 15:52 ` Johannes Schindelin
2017-05-10 19:55 ` Torstem Bögershausen
2017-05-11 2:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79dd912-f798-7fa3-e8d0-cf90aef53bd5@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).