From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org, larsxschneider@gmail.com
Subject: Re: [PATCH v3 1/1] t0027: tests are not expensive; remove t0025
Date: Wed, 10 May 2017 17:52:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1705101746470.146734@virtualbox> (raw)
In-Reply-To: <20170510140619.22808-1-tboegi@web.de>
[-- Attachment #1: Type: text/plain, Size: 2088 bytes --]
Hi,
On Wed, 10 May 2017, tboegi@web.de wrote:
> From: Torsten Bögershausen <tboegi@web.de>
>
> The purpose of t0027 is to test all CRLF related conversions at "git checkout"
> and "git add".
>
> Running t0027 under Git for Windows takes 3-4 minutes, so the whole script had
> been marked as "EXPENSIVE".
>
> The source code for "Git for Windows" overrides this since 2014:
> "t0027 is marked expensive, but really, for MinGW we want to run these
> tests always."
>
> Recent "stress" tests show that t0025 if flaky, reported by Lars Schneider,
> larsxschneider@gmail.com
>
> All tests in t0025 are covered by t0027 already, so that t0025 can be retired.
> t0027 takes less than 14 seconds under Linux, and 63 seconds under Mac Os X,
> and this is more or less the same with a SSD or a spinning disk.
>
> Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
This is still formatted very awkwardly. How about this instead (I fixed
the formatting, reworded a little here and there, and fixed the order of
the footers)?
-- snipsnap --
From: Torsten Bögershausen <tboegi@web.de>
The purpose of t0027 is to test all CRLF related conversions at "git
checkout" and "git add". Running t0027 under Git for Windows takes 3-4
minutes, so the whole script had been marked as "EXPENSIVE".
However, the "Git for Windows" fork overrides this since 2014: "t0027
is marked expensive, but really, for MinGW we want to run these tests
always."
The test seems not to be expensive on other platforms at all: it takes
less than 14 seconds under Linux, and 63 seconds under Mac Os X, and
this is more or less the same with a SSD or a spinning disk.
So let's drop the "EXPENSIVE" prereq.
While at it, retire t0025: Recent "stress" tests show that t0025 if
flaky, reported by Lars Schneider <larsxschneider@gmail.com>, but all
tests in t0025 are covered by t0027 already.
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
next prev parent reply other threads:[~2017-05-10 15:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <461E433C-DC8E-42FE-9B23-4A76BEFE0D11@gmail.com>
2017-04-24 17:00 ` t0025 flaky on OSX Torsten Bögershausen
2017-04-24 19:48 ` Torsten Bögershausen
2017-04-25 17:42 ` Lars Schneider
2017-04-26 4:12 ` Torsten Bögershausen
2017-04-26 19:41 ` Lars Schneider
2017-04-29 15:34 ` [PATCH/RFC 1/1] t0027: Some tests are not expensive tboegi
2017-05-01 3:07 ` Junio C Hamano
2017-05-01 4:52 ` Torsten Bögershausen
2017-05-02 15:56 ` [PATCH v2 1/1] t0027: tests are not expensive; remove t0025 tboegi
2017-05-02 16:11 ` Johannes Schindelin
2017-05-09 1:29 ` Junio C Hamano
2017-05-09 4:12 ` Torsten Bögershausen
2017-05-10 14:06 ` [PATCH v3 " tboegi
2017-05-10 15:52 ` Johannes Schindelin [this message]
2017-05-10 19:55 ` Torstem Bögershausen
2017-05-11 2:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1705101746470.146734@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).