From: Michael J Gruber <git@drmicha.warpmail.net>
To: Leandro Lucarella <leandro.lucarella@sociomantic.com>,
Jeff King <peff@peff.net>
Cc: Mehul Jain <mehul.jain2029@gmail.com>, git@vger.kernel.org
Subject: Re: 2.10.0: git log --oneline prints gpg signatures in 4 lines
Date: Wed, 21 Sep 2016 17:05:05 +0200 [thread overview]
Message-ID: <ebdb9974-9ab8-1e8a-f678-847a798f4c44@drmicha.warpmail.net> (raw)
In-Reply-To: <20160921155300.79252e68@labs-064.localdomain>
Leandro Lucarella venit, vidit, dixit 21.09.2016 15:53:
> On Tue, 20 Sep 2016 19:15:33 -0400
> Jeff King <peff@peff.net> wrote:
>
>> On Tue, Sep 20, 2016 at 05:09:54PM +0200, Leandro Lucarella wrote:
>>
>>> Hi, starting from 2.10.0 I noticed that when using git log
>>> --oneline, if commits are signed with GPG, now the signatures are
>>> printed too, and it takes 3 lines for the signature information + 1
>>> line for the title of the commit, so suddenly --oneline became
>>> --fourline :)
>>>
>>> Is this really intended?
>>
>> I don't think anything has changed here in 2.10. Running "git log
>> --oneline --show-signature" has _always_ been horribly ugly. However,
>> 2.10 did introduce the "log.showsignature" config, which makes "git
>> log --oneline" pretty unusable when it is enabled. Ditto for
>> one-liner uses of "--format".
>>
>> I think we should probably ignore the config entirely when using any
>> of the one-liner formats (and I'd include --format, too, even though
>> it can sometimes be multi-line; it already has %GG to include that
>> information as appropriate).
>
> Woops! Definitely it shouldn't be added when --format is used, this is
> also breaking some scripts I have using git log --format to get some
> information about commits, and GPG information is being output even
> when there is anything about GPG requested in the chosen format.
>
> I guess I will disable log.showsignatures for now... :(
>
I guess that's one of the reasons why I didn't like that config option
to begin with. There's a flood of these config "convenience" options
lately where we have to special case for scripting... Aliases must have
become old school or something.
Note that "git log --show-notes", "git log --oneline --raw", "git log
--oneline -p" and similar are not "one line" either. So
"--show-signature" behaves just like all others.
git log --format="%h %G? %s"
or a colored version thereof may be what you want to alias as "log1" or
such.
Cheers,
Michael
next prev parent reply other threads:[~2016-09-21 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:09 2.10.0: git log --oneline prints gpg signatures in 4 lines Leandro Lucarella
2016-09-20 23:15 ` Jeff King
2016-09-21 10:24 ` Leandro Lucarella
2016-09-21 13:53 ` Leandro Lucarella
2016-09-21 15:05 ` Michael J Gruber [this message]
2016-09-21 16:26 ` Junio C Hamano
2016-09-21 16:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebdb9974-9ab8-1e8a-f678-847a798f4c44@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=leandro.lucarella@sociomantic.com \
--cc=mehul.jain2029@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).