* [git-gui] Amending doesn't preserve timestamp
@ 2017-02-12 20:50 Juraj
2017-02-12 21:33 ` Igor Djordjevic BugA
[not found] ` <8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr>
0 siblings, 2 replies; 7+ messages in thread
From: Juraj @ 2017-02-12 20:50 UTC (permalink / raw)
To: git
I've just noticed that amending a commit from git-gui uses the time of
amending as the new timestamp of the commit, whereas git commit
--amend preserves the original timestamp. Maybe the two should work
the same, whatever it is decided to be the standard behavior.
Juraj
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [git-gui] Amending doesn't preserve timestamp 2017-02-12 20:50 [git-gui] Amending doesn't preserve timestamp Juraj @ 2017-02-12 21:33 ` Igor Djordjevic BugA [not found] ` <8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr> 1 sibling, 0 replies; 7+ messages in thread From: Igor Djordjevic BugA @ 2017-02-12 21:33 UTC (permalink / raw) To: Juraj, git On 12/02/2017 21:50, Juraj wrote: > I've just noticed that amending a commit from git-gui uses the time of > amending as the new timestamp of the commit, whereas git commit > --amend preserves the original timestamp. Maybe the two should work > the same, whatever it is decided to be the standard behavior. > > Juraj > Hi Juraj, Just to report that it seems to work as expected on my end...? Amending through both command line and git-gui preserves author date and updates commiter date. git version 2.11.1.windows.1 git-gui version 0.21.GITGUI Tcl/Tk version 8.6.6 Regards, BugA ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr>]
* Re: [git-gui] Amending doesn't preserve timestamp [not found] ` <8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr> @ 2017-02-12 21:40 ` Juraj 2017-02-12 23:06 ` Igor Djordjevic BugA [not found] ` <70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr> 0 siblings, 2 replies; 7+ messages in thread From: Juraj @ 2017-02-12 21:40 UTC (permalink / raw) To: Igor Djordjevic BugA; +Cc: git@vger.kernel.org Hi Igor, I forgot to write the version I'm using. It's on Ubuntu 16.04, git-gui package version 1:2.7.4-0ubuntu1 (--version: git-gui version 0.20.0), git version 2.7.4, tcl and tk 8.6.0+9. Perhaps it got fixed in a newer version, in that case, my bad for not checking before posting. Thanks, Juraj ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [git-gui] Amending doesn't preserve timestamp 2017-02-12 21:40 ` Juraj @ 2017-02-12 23:06 ` Igor Djordjevic BugA [not found] ` <70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr> 1 sibling, 0 replies; 7+ messages in thread From: Igor Djordjevic BugA @ 2017-02-12 23:06 UTC (permalink / raw) To: Juraj; +Cc: git@vger.kernel.org On 12/02/2017 22:40, Juraj wrote: > Hi Igor, > > I forgot to write the version I'm using. It's on Ubuntu 16.04, git-gui > package version 1:2.7.4-0ubuntu1 (--version: git-gui version 0.20.0), > git version 2.7.4, tcl and tk 8.6.0+9. Perhaps it got fixed in a newer > version, in that case, my bad for not checking before posting. > > Thanks, > Juraj Hi Juraj, Indeed, if I`m reading it correctly, it seems to be addressed in git-gui version 0.21.0[1], introduced in git version 2.11.0[2] on 2016-11-29 ("git-gui: Do not reset author details on amend", 2016-04-11[3], referencing an old bug report[4]). Regards, BugA [1] https://public-inbox.org/git/878ttji701.fsf@red.patthoyts.tk/ [2] https://public-inbox.org/git/xmqqmvgidlsg.fsf@gitster.mtv.corp.google.com/ [3] https://public-inbox.org/git/1462458182-4488-1-git-send-email-orgads@gmail.com/ [4] https://public-inbox.org/git/CAGHpTB+35j0njmCZ0uCgBVroe=Ma7HLnn6fDty8yebKWgEmECg@mail.gmail.com/ ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr>]
* Re: [git-gui] Amending doesn't preserve timestamp [not found] ` <70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr> @ 2017-03-23 14:26 ` Juraj Oršulić 2017-03-23 22:54 ` Igor Djordjevic [not found] ` <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr> 0 siblings, 2 replies; 7+ messages in thread From: Juraj Oršulić @ 2017-03-23 14:26 UTC (permalink / raw) To: Igor Djordjevic BugA; +Cc: git@vger.kernel.org Hello Igor (and others), I have something else to report about the commit amend functionality in git-gui, and I think it could be related to my original question. It seems that git-gui messes up international signs on amending. E.g. I use git gui to make a commit, and all is OK: commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021 Author: Juraj Oršulić <juraj.orsulic@fer.hr> I open git gui again, click "Amend Last Commit", press "Commit", and I get this in git log: commit 6e09ff9edcef863d92f02cf86e0307c27171aec0 Author: Juraj OrÅ¡uliÄ<U+0087> <juraj.orsulic@fer.hr> Does anyone have any idea what could be the cause? I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72. Thanks, Juraj ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [git-gui] Amending doesn't preserve timestamp 2017-03-23 14:26 ` Juraj Oršulić @ 2017-03-23 22:54 ` Igor Djordjevic [not found] ` <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr> 1 sibling, 0 replies; 7+ messages in thread From: Igor Djordjevic @ 2017-03-23 22:54 UTC (permalink / raw) To: Juraj Oršulić; +Cc: git@vger.kernel.org Hi Juraj, On 23/03/2017 15:26, Juraj Oršulić wrote: > Hello Igor (and others), I have something else to report about the > commit amend functionality in git-gui, and I think it could be > related to my original question. It seems that git-gui messes up > international signs on amending. > > E.g. I use git gui to make a commit, and all is OK: > > commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021 > Author: Juraj Oršulić <juraj.orsulic@fer.hr> > > I open git gui again, click "Amend Last Commit", press "Commit", and I > get this in git log: > > commit 6e09ff9edcef863d92f02cf86e0307c27171aec0 > Author: Juraj OrÅ¡uliÄ<U+0087> <juraj.orsulic@fer.hr> > > > Does anyone have any idea what could be the cause? > > I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on > http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72. Yes, I can confirm this. git version 2.12.1.windows.1 git-gui version 0.21.GITGUI Tcl/Tk version 8.6.6 That said, it seems there are quite some topics about it, like [1], [2], [3] and [4], but the most interesting one could be [5], having some kind of a "workaround" at the end as well. I`ve tried replacing the "commit.tcl" file as proposed, and it seems to work correctly -- just please do note that it actually reverts the file in question to an older version, maybe (re)introducing other bugs while fixing this specific one, so it could be something you may want to investigate into a bit more before actually using it for good. P.S. It might be a good idea to start a new topic in situations like this (send out a new e-mail instead of a reply), keeping unrelated discussions separated and helping interested parties spotting the new topic more easily. Regards, Buga [1] https://public-inbox.org/git/588ac268-0a1b-6787-e6a1-4164e7e9a784@b-i-t.de/T/#ea05ebbde162f9c230a2cc4f7099363aed68768f6 [2] https://public-inbox.org/git/52E1627956F20E458D872C5961027EDC654FE17C@SGDS00759.zf-lenksysteme.net/T/#m0baea8c76e79f25bf92ca0deabe38efec2ee168d [3] https://public-inbox.org/git/50913C58.2000200@drmicha.warpmail.net/T/#m72664106ad3070235ea2628b61fc6203fbb5563e [4] https://public-inbox.org/git/20071212091744.GA5377@pvv.org/T/#m8490dd348389b4eea82eb1bdaab69227c946de19 [5] https://github.com/git-for-windows/git/issues/761 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr>]
* Re: [git-gui] Amending doesn't preserve timestamp [not found] ` <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr> @ 2017-03-24 10:23 ` Juraj Oršulić 0 siblings, 0 replies; 7+ messages in thread From: Juraj Oršulić @ 2017-03-24 10:23 UTC (permalink / raw) To: Igor Djordjevic; +Cc: git@vger.kernel.org Hi Igor! Thanks on for thoroughly searching the mailing list and on your suggestions. I hope that someone will come up with a fix that both preserves the author details and date correctly. Regards, Juraj On Thu, Mar 23, 2017 at 11:54 PM, Igor Djordjevic <igor.d.djordjevic@gmail.com> wrote: > Hi Juraj, > > On 23/03/2017 15:26, Juraj Oršulić wrote: >> Hello Igor (and others), I have something else to report about the >> commit amend functionality in git-gui, and I think it could be >> related to my original question. It seems that git-gui messes up >> international signs on amending. >> >> E.g. I use git gui to make a commit, and all is OK: >> >> commit ef24b133dda6c18b8ef01b1a38f9e049d87f2021 >> Author: Juraj Oršulić <juraj.orsulic@fer.hr> >> >> I open git gui again, click "Amend Last Commit", press "Commit", and I >> get this in git log: >> >> commit 6e09ff9edcef863d92f02cf86e0307c27171aec0 >> Author: Juraj OrÅ¡uliÄ<U+0087> <juraj.orsulic@fer.hr> >> >> >> Does anyone have any idea what could be the cause? >> >> I tested this on Ubuntu 16.04 and HEAD vearsion of git-gui on >> http://repo.or.cz/git-gui.git, currently 0.21.0.5.g5ab72. > > Yes, I can confirm this. > > git version 2.12.1.windows.1 > git-gui version 0.21.GITGUI > Tcl/Tk version 8.6.6 > > That said, it seems there are quite some topics about it, like [1], > [2], [3] and [4], but the most interesting one could be [5], having > some kind of a "workaround" at the end as well. > > I`ve tried replacing the "commit.tcl" file as proposed, and it seems > to work correctly -- just please do note that it actually reverts the > file in question to an older version, maybe (re)introducing other > bugs while fixing this specific one, so it could be something you may > want to investigate into a bit more before actually using it for good. > > P.S. It might be a good idea to start a new topic in situations like > this (send out a new e-mail instead of a reply), keeping unrelated > discussions separated and helping interested parties spotting the new > topic more easily. > > Regards, > Buga > > [1] https://public-inbox.org/git/588ac268-0a1b-6787-e6a1-4164e7e9a784@b-i-t.de/T/#ea05ebbde162f9c230a2cc4f7099363aed68768f6 > [2] https://public-inbox.org/git/52E1627956F20E458D872C5961027EDC654FE17C@SGDS00759.zf-lenksysteme.net/T/#m0baea8c76e79f25bf92ca0deabe38efec2ee168d > [3] https://public-inbox.org/git/50913C58.2000200@drmicha.warpmail.net/T/#m72664106ad3070235ea2628b61fc6203fbb5563e > [4] https://public-inbox.org/git/20071212091744.GA5377@pvv.org/T/#m8490dd348389b4eea82eb1bdaab69227c946de19 > [5] https://github.com/git-for-windows/git/issues/761 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-24 10:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-12 20:50 [git-gui] Amending doesn't preserve timestamp Juraj
2017-02-12 21:33 ` Igor Djordjevic BugA
[not found] ` <8a1179dfbb7743b6b8c23570306120b7@MAIL.fer.hr>
2017-02-12 21:40 ` Juraj
2017-02-12 23:06 ` Igor Djordjevic BugA
[not found] ` <70bd7cfd05ae459dac94625bb78c26c3@MAIL.fer.hr>
2017-03-23 14:26 ` Juraj Oršulić
2017-03-23 22:54 ` Igor Djordjevic
[not found] ` <42d1bc3de3bc488497928b4335f1dc41@MAIL.fer.hr>
2017-03-24 10:23 ` Juraj Oršulić
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).