From: Derrick Stolee <derrickstolee@github.com>
To: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Victoria Dye <vdye@github.com>,
git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] mv: integrate with sparse-index
Date: Wed, 23 Mar 2022 09:10:52 -0400 [thread overview]
Message-ID: <e61303b8-10ad-5b5b-d48b-cac89ac53d29@github.com> (raw)
In-Reply-To: <CAJyCBORkauHAdDiHjQ2Agj3bNhLNPtKk-VW5=bNmBfNuQtv7hA@mail.gmail.com>
On 3/22/2022 4:38 AM, Shaoxuan Yuan wrote:
> Hi all,
>
> On Tue, Mar 22, 2022 at 3:45 AM Derrick Stolee <derrickstolee@github.com> wrote:
>> I'm particularly surprised in how much 'git mv' doesn't work very
>> well in the sparse-checkout environment already, which makes things
>> more difficult than "just" doing the normal sparse index things.
>>
>> It's good that we are discovering them and working to fix them.
>>
>> Thanks,
>> -Stolee
>
> Really appreciate the mentoring and tips here, I'm trying to make some progress
> now. The problems facing here certainly push me to explore more and know
> better about the codebase. Appreciate all the help :-)
A thought occurred to me while thinking about these difficulties:
perhaps it is better to start with 'git rm' since that does only
half of what 'git mv' does. It should be a smaller lift as a first
contribution. There is even a clear loop that is marked with "TODO:
audit for interaction with sparse-index."
As we've discovered in this thread, the direction for integrating
a builtin with the sparse index should follow this outline:
0. Test the builtin in t1092 with interactions inside and outside
of the sparse-checkout cone.*
1. Add command_requires_full_index = 0 line to the builtin.
2. Check for failures and diagnose them.
3. Check for index expansion and remove them as necessary.
(Go back to 2.)
4. Run performance tests.
(*) This step is the one we failed to focus enough on previously.
Of course, if you've already gotten really far on 'mv' and don't
want to switch context, then keep at it.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-03-23 13:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:01 [RFC PATCH 0/1] mv: integrate with sparse-index Shaoxuan Yuan
2022-03-15 10:01 ` [RFC PATCH 1/1] " Shaoxuan Yuan
2022-03-15 16:07 ` Victoria Dye
2022-03-15 17:14 ` Derrick Stolee
2022-03-16 3:29 ` Shaoxuan Yuan
2022-03-17 8:37 ` Shaoxuan Yuan
2022-03-16 3:18 ` Shaoxuan Yuan
2022-03-16 10:45 ` Shaoxuan Yuan
2022-03-16 13:34 ` Derrick Stolee
2022-03-16 14:46 ` Shaoxuan Yuan
2022-03-17 21:57 ` Victoria Dye
2022-03-18 1:00 ` Junio C Hamano
2022-03-21 15:20 ` Derrick Stolee
2022-03-21 19:14 ` Junio C Hamano
2022-03-21 19:45 ` Derrick Stolee
2022-03-22 8:38 ` Shaoxuan Yuan
2022-03-23 13:10 ` Derrick Stolee [this message]
2022-03-23 21:33 ` Junio C Hamano
2022-03-27 3:48 ` Shaoxuan Yuan
2022-03-28 13:32 ` Derrick Stolee
2022-03-15 17:23 ` Junio C Hamano
2022-03-15 20:00 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e61303b8-10ad-5b5b-d48b-cac89ac53d29@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=shaoxuan.yuan02@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).