From: Derrick Stolee <derrickstolee@github.com>
To: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>,
Victoria Dye <vdye@github.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] mv: integrate with sparse-index
Date: Wed, 16 Mar 2022 09:34:22 -0400 [thread overview]
Message-ID: <675c7681-c495-727d-1262-ee8c6a5c8ce5@github.com> (raw)
In-Reply-To: <CAJyCBORDOJUwTzOC+hYwGGPUBCXST0_mBdwRLh2N+cA=5k0d4A@mail.gmail.com>
On 3/16/2022 6:45 AM, Shaoxuan Yuan wrote:
> Hi Victoria,
>
> Just found an interesting (probably) behavior.
>
> In the `sparse-checkout` directory created in `init_repos()` in t1092, if I
> say:
>
> $ mkdir folder3
> $ touch folder3/a
The issue here is that this file is "untracked", not just outside
of the sparse-checkout cone.
> $ git mv folder3/a deep
>
> and git will prompt:
>
> "fatal: not under version control, source=folder3/a, destination=deep/a"
>
> And if I say:
>
> $ git mv folder3 deep
>
> git will prompt:
>
> "fatal: source directory is empty, source=folder3, destination=deep/folder3"
>
> What I am wondering is that file `folder3/a` is outside of sparse-checkout cone,
> should `git mv` instead prompts with `advise_on_updating_sparse_paths()` or this
> "not under version control" alarm is acceptable?
Instead, what about
git mv folder2/a deep/new
since folder2/a is a tracked file, just not in the working tree
since it is outside the sparse-checkout cone.
(If it fails, then it should fail the same with and without the
sparse index, which is what "test_sparse_match" is for.)
Thanks,
-Stolee
next prev parent reply other threads:[~2022-03-16 13:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:01 [RFC PATCH 0/1] mv: integrate with sparse-index Shaoxuan Yuan
2022-03-15 10:01 ` [RFC PATCH 1/1] " Shaoxuan Yuan
2022-03-15 16:07 ` Victoria Dye
2022-03-15 17:14 ` Derrick Stolee
2022-03-16 3:29 ` Shaoxuan Yuan
2022-03-17 8:37 ` Shaoxuan Yuan
2022-03-16 3:18 ` Shaoxuan Yuan
2022-03-16 10:45 ` Shaoxuan Yuan
2022-03-16 13:34 ` Derrick Stolee [this message]
2022-03-16 14:46 ` Shaoxuan Yuan
2022-03-17 21:57 ` Victoria Dye
2022-03-18 1:00 ` Junio C Hamano
2022-03-21 15:20 ` Derrick Stolee
2022-03-21 19:14 ` Junio C Hamano
2022-03-21 19:45 ` Derrick Stolee
2022-03-22 8:38 ` Shaoxuan Yuan
2022-03-23 13:10 ` Derrick Stolee
2022-03-23 21:33 ` Junio C Hamano
2022-03-27 3:48 ` Shaoxuan Yuan
2022-03-28 13:32 ` Derrick Stolee
2022-03-15 17:23 ` Junio C Hamano
2022-03-15 20:00 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675c7681-c495-727d-1262-ee8c6a5c8ce5@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=shaoxuan.yuan02@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).