git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeremy Huddleston Sequoia <jeremyhu@freedesktop.org>,
	t.gummerer@gmail.com, git@vger.kernel.org
Subject: Re: git 2.10.1 test regression in t3700-add.sh
Date: Mon, 10 Oct 2016 21:14:10 +0200	[thread overview]
Message-ID: <dddae1eb-347c-a285-0699-31f30eb924d8@kdbg.org> (raw)
In-Reply-To: <xmqq8ttwgkyo.fsf@gitster.mtv.corp.google.com>

Am 10.10.2016 um 19:41 schrieb Junio C Hamano:
> I also notice that the problematic test uses "chmod 755"; don't we
> need POSIXPERM prerequisite on this test, too, I wonder?

Good point. Without POSIXPERM the test demonstrate that, since chmod 755 
is basically a noop, the following add --chmod=-x does not leave an x 
bit in the index when there was none there in the first place. I think 
it does not hurt to keep the test even though it does not quite test the 
same thing as on POSIXPERM enabled systems.

-- Hannes


  parent reply	other threads:[~2016-10-10 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  0:15 git 2.10.1 test regression in t3700-add.sh Jeremy Huddleston Sequoia
2016-10-10  2:51 ` Jeremy Huddleston Sequoia
2016-10-10  3:22   ` Jeremy Huddleston Sequoia
2016-10-10  3:46     ` Jeremy Huddleston Sequoia
2016-10-10 17:41       ` Junio C Hamano
2016-10-10 17:46         ` Junio C Hamano
2016-10-10 19:14         ` Johannes Sixt [this message]
2016-10-11 23:32         ` Jeremy Huddleston Sequoia
2016-10-12  5:59           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dddae1eb-347c-a285-0699-31f30eb924d8@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeremyhu@freedesktop.org \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).