From: Jeremy Huddleston Sequoia <jeremyhu@freedesktop.org>
To: t.gummerer@gmail.com
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: git 2.10.1 test regression in t3700-add.sh
Date: Sun, 9 Oct 2016 19:51:49 -0700 [thread overview]
Message-ID: <98EB348E-221D-488C-A466-1FACB1C768FF@freedesktop.org> (raw)
In-Reply-To: <A433322C-2B75-4B4B-A8CC-BAC3179EE7A7@freedesktop.org>
[-- Attachment #1: Type: text/plain, Size: 2237 bytes --]
> On Oct 9, 2016, at 17:15, Jeremy Huddleston Sequoia <jeremyhu@freedesktop.org> wrote:
>
> Hi Thomas,
>
> I wanted to let you know that this patch of yours, which landed in git 2.10.1, introduced some test failures, seen on macOS.
>
> Let me know if you need any additional information to track these down.
>
> Thanks,
> Jeremy
>
> not ok 40 - git add --chmod=[+-]x changes index with already added file
> #
> # echo foo >foo3 &&
> # git add foo3 &&
> # git add --chmod=+x foo3 &&
> # test_mode_in_index 100755 foo3 &&
> # echo foo >xfoo3 &&
> # chmod 755 xfoo3 &&
> # git add xfoo3 &&
> # git add --chmod=-x xfoo3 &&
> # test_mode_in_index 100644 xfoo3
> #
>
> commit 610d55af0f082f6b866dc858e144c03d8ed4424c
> Author: Thomas Gummerer <t.gummerer@gmail.com>
> Date: Wed Sep 14 22:07:47 2016 +0100
>
> add: modify already added files when --chmod is given
>
> When the chmod option was added to git add, it was hooked up to the diff
> machinery, meaning that it only works when the version in the index
> differs from the version on disk.
>
> As the option was supposed to mirror the chmod option in update-index,
> which always changes the mode in the index, regardless of the status of
> the file, make sure the option behaves the same way in git add.
>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This failure looks odd. I'll dig into it a bit more as it looks like something odd is going on here...
expecting success:
echo foo >foo3 &&
git add foo3 &&
git add --chmod=+x foo3 &&
test_mode_in_index 100755 foo3 &&
echo foo >xfoo3 &&
chmod 755 xfoo3 &&
git add xfoo3 &&
git add --chmod=-x xfoo3 &&
test_mode_in_index 100644 xfoo3
pass
cannot chmod 'xfoo3'fail
120000 c5c4ca97a3a080c32920941b665e94a997901491 0 xfoo3
not ok 40 - git add --chmod=[+-]x changes index with already added file
#
# echo foo >foo3 &&
# git add foo3 &&
# git add --chmod=+x foo3 &&
# test_mode_in_index 100755 foo3 &&
# echo foo >xfoo3 &&
# chmod 755 xfoo3 &&
# git add xfoo3 &&
# git add --chmod=-x xfoo3 &&
# test_mode_in_index 100644 xfoo3
#
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4465 bytes --]
next prev parent reply other threads:[~2016-10-10 2:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 0:15 git 2.10.1 test regression in t3700-add.sh Jeremy Huddleston Sequoia
2016-10-10 2:51 ` Jeremy Huddleston Sequoia [this message]
2016-10-10 3:22 ` Jeremy Huddleston Sequoia
2016-10-10 3:46 ` Jeremy Huddleston Sequoia
2016-10-10 17:41 ` Junio C Hamano
2016-10-10 17:46 ` Junio C Hamano
2016-10-10 19:14 ` Johannes Sixt
2016-10-11 23:32 ` Jeremy Huddleston Sequoia
2016-10-12 5:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98EB348E-221D-488C-A466-1FACB1C768FF@freedesktop.org \
--to=jeremyhu@freedesktop.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).