From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2015, #06; Wed, 24)
Date: Thu, 25 Jun 2015 13:04:30 +0200 [thread overview]
Message-ID: <d825b05938778f4ee911cbb8c3c8573b@www.dscho.org> (raw)
In-Reply-To: <CAGZ79kby0RaKiS2e4o7O7OyLGCftMYVJppvATyPxpzJUOe59jw@mail.gmail.com>
Hi,
On 2015-06-25 03:01, Stefan Beller wrote:
>> * pt/pull-builtin (2015-06-18) 19 commits
>> - pull: remove redirection to git-pull.sh
>> - pull --rebase: error on no merge candidate cases
>> - pull --rebase: exit early when the working directory is dirty
>> - pull: configure --rebase via branch.<name>.rebase or pull.rebase
>> - pull: teach git pull about --rebase
>> - pull: set reflog message
>> - pull: implement pulling into an unborn branch
>> - pull: fast-forward working tree if head is updated
>> - pull: check if in unresolved merge state
>> - pull: support pull.ff config
>> - pull: error on no merge candidates
>> - pull: pass git-fetch's options to git-fetch
>> - pull: pass git-merge's options to git-merge
>> - pull: pass verbosity, --progress flags to fetch and merge
>> - pull: implement fetch + merge
>> - pull: implement skeletal builtin pull
>> - argv-array: implement argv_array_pushv()
>> - parse-options-cb: implement parse_opt_passthru_argv()
>> - parse-options-cb: implement parse_opt_passthru()
>>
>> Reimplement 'git pull' in C.
>>
>> This is v4 ($gmane/271943).
>> Comments from mentors and others?
>
> I think the series is good as is.
I just had a fresh look. Some comments:
- I *think* that the current `recreate_opt()` is fine, but if it is used more, we will have to quote the arguments to guard against spaces and quotes and whatnot
- There is a loop
for (; *argv; argv++)
argv_array_push(array, *argv);
which might want to be written as
while (*argv)
argv_array_push(array, *(argv)++);
to conform better with Git's coding style, but this one is not crucial at all.
Having said that, I really think this is impressive work, and not only the outcome. It is a real pleasure to have you, Paul!
I vote for merging, too,
Dscho
next prev parent reply other threads:[~2015-06-25 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 21:14 What's cooking in git.git (Jun 2015, #06; Wed, 24) Junio C Hamano
2015-06-25 1:01 ` Stefan Beller
2015-06-25 11:04 ` Johannes Schindelin [this message]
2015-06-25 13:14 ` Junio C Hamano
2015-06-25 18:14 ` Johannes Schindelin
2015-06-29 14:32 ` Tony Finch
2015-06-29 20:02 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d825b05938778f4ee911cbb8c3c8573b@www.dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).