git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2015, #06; Wed, 24)
Date: Thu, 25 Jun 2015 20:14:06 +0200	[thread overview]
Message-ID: <20853ca02f86d3e524fa961eef1f1d2e@www.dscho.org> (raw)
In-Reply-To: <xmqqtwtw0w20.fsf@gitster.dls.corp.google.com>

Hi Junio,

On 2015-06-25 15:14, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> - I *think* that the current `recreate_opt()` is fine, but if it
>> is used more, we will have to quote the arguments to guard against
>> spaces and quotes and whatnot
> 
> I admit that that was the reaction I had when I saw it for the first
> time, until I realized how it is used.  And this one I have to
> disagree.  recreate-opt is used to munge a single argument, suitable
> to be placed into argv[] for execv() like thing---there is no need
> for shell quoting there.  It is a job for the caller that gets its
> result to shell quote if it wants to pass the result to a shell.

Ah yes, no single command-line is constructed from those reconstructed options. So yes, you're right, all is good!

Ciao,
Dscho

  reply	other threads:[~2015-06-25 18:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 21:14 What's cooking in git.git (Jun 2015, #06; Wed, 24) Junio C Hamano
2015-06-25  1:01 ` Stefan Beller
2015-06-25 11:04   ` Johannes Schindelin
2015-06-25 13:14     ` Junio C Hamano
2015-06-25 18:14       ` Johannes Schindelin [this message]
2015-06-29 14:32 ` Tony Finch
2015-06-29 20:02 ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20853ca02f86d3e524fa961eef1f1d2e@www.dscho.org \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).