From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] valgrind: support test helpers
Date: Sat, 29 Oct 2016 11:43:32 +0200 [thread overview]
Message-ID: <d6485418-e009-f808-8ee2-a06e60c60d0d@web.de> (raw)
In-Reply-To: <xmqqshrg3af4.fsf@gitster.mtv.corp.google.com>
Am 28.10.2016 um 14:50 schrieb Junio C Hamano:
> Hmph. I somehow thought this was supposed to have been fixed by
> 503e224180 ("t/test-lib.sh: fix running tests with --valgrind",
> 2016-07-11) already.
Its title seems to indicate that intention. Probably the quickest test
script that calls a helper is t0009-prio-queue.sh, and without my patch
it reports something like this, unfortunately:
expecting success:
test-prio-queue 2 6 3 10 9 5 7 4 5 8 1 dump >actual &&
test_cmp expect actual
./t0009-prio-queue.sh: 4: eval: test-prio-queue: not found
not ok 1 - basic ordering
#
# test-prio-queue 2 6 3 10 9 5 7 4 5 8 1 dump >actual &&
# test_cmp expect actual
#
René
prev parent reply other threads:[~2016-10-29 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 22:14 [PATCH] valgrind: support test helpers René Scharfe
2016-10-28 8:51 ` Johannes Schindelin
2016-10-29 9:44 ` René Scharfe
2016-10-28 12:50 ` Junio C Hamano
2016-10-29 9:43 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6485418-e009-f808-8ee2-a06e60c60d0d@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).