From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] valgrind: support test helpers
Date: Fri, 28 Oct 2016 10:51:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610281050220.3264@virtualbox> (raw)
In-Reply-To: <71c3d13a-fa29-75d3-50ac-81978c08f552@web.de>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Hi,
On Fri, 28 Oct 2016, René Scharfe wrote:
> Tests run with --valgrind call git commands through a wrapper script
> that invokes valgrind on them. This script (valgrind.sh) is in turn
> invoked through symlinks created for each command in t/valgrind/bin/.
>
> Since e6e7530d (test helpers: move test-* to t/helper/ subdirectory)
> these symlinks have been broken for test helpers -- they point to the
> old locations in the root of the build directory. Fix that by teaching
> the code for creating the links about the new location of the binaries,
> and do the same in the wrapper script to allow it to find its payload.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
Apart from the missing accent ("é") in your SOB: ACK.
Ciao,
Dscho
next prev parent reply other threads:[~2016-10-28 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 22:14 [PATCH] valgrind: support test helpers René Scharfe
2016-10-28 8:51 ` Johannes Schindelin [this message]
2016-10-29 9:44 ` René Scharfe
2016-10-28 12:50 ` Junio C Hamano
2016-10-29 9:43 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610281050220.3264@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).