From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
To: Derrick Stolee <derrickstolee@github.com>, git@vger.kernel.org
Cc: vdye@github.com
Subject: Re: [PATCH v1 3/4] rm: expand the index only when necessary
Date: Fri, 5 Aug 2022 16:07:51 +0800 [thread overview]
Message-ID: <d31d7ea2-4b7e-feb3-9d67-066520e0d053@gmail.com> (raw)
In-Reply-To: <475e8617-2adf-c75a-b697-d239dc4830b8@github.com>
On 8/3/2022 10:40 PM, Derrick Stolee wrote:
> On 8/3/2022 12:51 AM, Shaoxuan Yuan wrote:
>> Originally, rm a pathspec that is out-of-cone in a sparse-index
>> environment, Git dies with "pathspec '<x>' did not match any files",
>> mainly because it does not expand the index so nothing is matched.
>
> This paragraph appears to be assuming that we've stopped expanding the
> sparse index already. It might be worthwhile to rewrite this to say
> "Before integrating 'git rm' with the sparse index, we need to..." or
> something like that.
I have absolutely no idea why I wrote this paragraph this way, maybe
I was zoning out composing it. Will fix.
>> Remove the `ensure_full_index()` method so `git-rm` does not always
>> expand the index when the expansion is unnecessary, i.e. when
>> <pathspec> does not have any possibilities to match anything outside
>> of sparse-checkout definition.
>>
>> Expand the index when the <pathspec> needs an expanded index, i.e. the
>> <pathspec> contains wildcard that may need a full-index or the
>> <pathspec> is simply outside of sparse-checkout definition.
>>
>> Signed-off-by: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
>> ---
>> builtin/rm.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/builtin/rm.c b/builtin/rm.c
>> index 84a935a16e..58ed924f0d 100644
>> --- a/builtin/rm.c
>> +++ b/builtin/rm.c
>> @@ -296,8 +296,9 @@ int cmd_rm(int argc, const char **argv, const
char *prefix)
>>
>> seen = xcalloc(pathspec.nr, 1);
>>
>> - /* TODO: audit for interaction with sparse-index. */
>> - ensure_full_index(&the_index);
>> + if (pathspec_needs_expanded_index(&the_index, &pathspec))
>> + ensure_full_index(&the_index);
>> +
>> for (i = 0; i < active_nr; i++) {
>> const struct cache_entry *ce = active_cache[i];
>
> Looking back on the tests in patch 1, I don't see any tests that really
> emphasize the kinds of pathspecs that could not ever integrate with the
> sparse index. They are all of the form "folder1/*" or similar, making it
> be something that could be seen as a prefix match. Such a pattern _could_
> be integrated carefully with the sparse index.
>
> Instead, something like `git rm "*/a"` would be much harder to integrate
> with the sparse index. Could we add a test (in this patch) that checks
> that kind of case. That would also help justify this as its own patch and
> not squashed with patch 4.
Makes sense. Will fix.
--
Thanks,
Shaoxuan
next prev parent reply other threads:[~2022-08-05 8:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 4:51 [PATCH v1 0/4] rm: integrate with sparse-index Shaoxuan Yuan
2022-08-03 4:51 ` [PATCH v1 1/4] t1092: add tests for `git-rm` Shaoxuan Yuan
2022-08-03 14:32 ` Derrick Stolee
2022-08-03 4:51 ` [PATCH v1 2/4] pathspec.h: move pathspec_needs_expanded_index() from reset.c to here Shaoxuan Yuan
2022-08-03 14:35 ` Derrick Stolee
2022-08-05 7:53 ` Shaoxuan Yuan
2022-08-03 4:51 ` [PATCH v1 3/4] rm: expand the index only when necessary Shaoxuan Yuan
2022-08-03 14:40 ` Derrick Stolee
2022-08-05 8:07 ` Shaoxuan Yuan [this message]
2022-08-03 4:51 ` [PATCH v1 4/4] rm: integrate with sparse-index Shaoxuan Yuan
2022-08-04 14:48 ` Derrick Stolee
2022-08-06 3:18 ` Shaoxuan Yuan
2022-08-07 4:13 ` [PATCH v2 0/4] " Shaoxuan Yuan
2022-08-07 4:13 ` [PATCH v2 1/4] t1092: add tests for `git-rm` Shaoxuan Yuan
2022-08-10 12:47 ` Derrick Stolee
2022-08-07 4:13 ` [PATCH v2 2/4] pathspec.h: move pathspec_needs_expanded_index() from reset.c to here Shaoxuan Yuan
2022-08-07 4:13 ` [PATCH v2 3/4] rm: expand the index only when necessary Shaoxuan Yuan
2022-08-10 0:24 ` Victoria Dye
2022-08-07 4:13 ` [PATCH v2 4/4] rm: integrate with sparse-index Shaoxuan Yuan
2022-08-08 17:24 ` [PATCH v2 0/4] " Junio C Hamano
2022-08-08 17:51 ` Victoria Dye
2022-08-08 19:01 ` Junio C Hamano
2022-08-10 0:27 ` Victoria Dye
2022-08-10 0:31 ` Shaoxuan Yuan
2022-08-12 18:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d31d7ea2-4b7e-feb3-9d67-066520e0d053@gmail.com \
--to=shaoxuan.yuan02@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).