From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
To: Victoria Dye <vdye@github.com>, git@vger.kernel.org
Cc: derrickstolee@github.com
Subject: Re: [PATCH v2 0/4] rm: integrate with sparse-index
Date: Wed, 10 Aug 2022 08:31:10 +0800 [thread overview]
Message-ID: <5b093198-8dc0-6dcc-8a3b-6762b6dc11bf@gmail.com> (raw)
In-Reply-To: <8a76428d-e236-88bc-ec67-356b4c6f67fa@github.com>
On 8/10/2022 8:27 AM, Victoria Dye wrote:
> Shaoxuan Yuan wrote:
>> ## Changes since PATCH v1 ##
>>
>> 1. Move `ensure_not_expanded` test from the first patch to the last one.
>>
>> 2. Mention the parameter of `pathspec_needs_expanded_index()` is
>> changed to use `struct index_state`.
>>
>> 3. Modify `ensure_not_expanded` method to record Git commands' stderr
>> and stdout.
>>
>> 4. Add a test 'rm pathspec expands index when necessary' to test
>> the expected index expansion when different pathspec is supplied.
>>
>> 5. Modify p2000 test by resetting the index in each test loop, so the
>> index modification is properly tested. Update the perf stats using
>> the results from the modified test.
>>
>> ## PATCH v1 info ##
>>
>> Turn on sparse-index feature within `git-rm` command.
>> Add necessary modifications and test them.
>
> Other than a completely optional recommendation on commit ordering
[1], I didn't have any comments on any individual patches. This series
looks good to me!
>
> [1]
https://lore.kernel.org/git/2c0cb658-cd5a-420a-d313-6839149b9b40@github.com/
Thanks for reviewing! :)
I think I'll just leave the commit ordering as-is.
--
Thanks,
Shaoxuan
next prev parent reply other threads:[~2022-08-10 0:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 4:51 [PATCH v1 0/4] rm: integrate with sparse-index Shaoxuan Yuan
2022-08-03 4:51 ` [PATCH v1 1/4] t1092: add tests for `git-rm` Shaoxuan Yuan
2022-08-03 14:32 ` Derrick Stolee
2022-08-03 4:51 ` [PATCH v1 2/4] pathspec.h: move pathspec_needs_expanded_index() from reset.c to here Shaoxuan Yuan
2022-08-03 14:35 ` Derrick Stolee
2022-08-05 7:53 ` Shaoxuan Yuan
2022-08-03 4:51 ` [PATCH v1 3/4] rm: expand the index only when necessary Shaoxuan Yuan
2022-08-03 14:40 ` Derrick Stolee
2022-08-05 8:07 ` Shaoxuan Yuan
2022-08-03 4:51 ` [PATCH v1 4/4] rm: integrate with sparse-index Shaoxuan Yuan
2022-08-04 14:48 ` Derrick Stolee
2022-08-06 3:18 ` Shaoxuan Yuan
2022-08-07 4:13 ` [PATCH v2 0/4] " Shaoxuan Yuan
2022-08-07 4:13 ` [PATCH v2 1/4] t1092: add tests for `git-rm` Shaoxuan Yuan
2022-08-10 12:47 ` Derrick Stolee
2022-08-07 4:13 ` [PATCH v2 2/4] pathspec.h: move pathspec_needs_expanded_index() from reset.c to here Shaoxuan Yuan
2022-08-07 4:13 ` [PATCH v2 3/4] rm: expand the index only when necessary Shaoxuan Yuan
2022-08-10 0:24 ` Victoria Dye
2022-08-07 4:13 ` [PATCH v2 4/4] rm: integrate with sparse-index Shaoxuan Yuan
2022-08-08 17:24 ` [PATCH v2 0/4] " Junio C Hamano
2022-08-08 17:51 ` Victoria Dye
2022-08-08 19:01 ` Junio C Hamano
2022-08-10 0:27 ` Victoria Dye
2022-08-10 0:31 ` Shaoxuan Yuan [this message]
2022-08-12 18:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b093198-8dc0-6dcc-8a3b-6762b6dc11bf@gmail.com \
--to=shaoxuan.yuan02@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).