From: Josh Steadmon <steadmon@google.com>
To: git@vger.kernel.org, gitster@pobox.com, me@ttaylorr.com
Subject: [PATCH v2 0/2] log negotiated protocol version.
Date: Wed, 4 Aug 2021 15:17:07 -0700 [thread overview]
Message-ID: <cover.1628115064.git.steadmon@google.com> (raw)
In-Reply-To: <f79ab95af6da3da710da2112cfcae4a042b7f7fb.1628020616.git.steadmon@google.com>
This series adds logging of the negotiated wire protocol via trace2 on
both client and server.
Changes in V2:
* adds a format_protocol_version() helper function
* adds tests
* bug fix: actually log on the server side, rather than twice on the
client
* moves the trace statement closer to the actual version negotiation
code
Josh Steadmon (2):
protocol: add protocol version formatting function
connect, protocol: log negotiated protocol version
connect.c | 3 +++
protocol.c | 17 +++++++++++++++++
protocol.h | 6 ++++++
t/t5705-session-id-in-capabilities.sh | 12 ++++++++++++
4 files changed, 38 insertions(+)
--
2.32.0.554.ge1b32706d8-goog
next prev parent reply other threads:[~2021-08-04 22:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 20:13 [PATCH] connect, protocol: log negotiated protocol version Josh Steadmon
2021-08-03 21:12 ` Taylor Blau
2021-08-04 21:37 ` Josh Steadmon
2021-08-04 21:56 ` Junio C Hamano
2021-08-04 22:17 ` Josh Steadmon [this message]
2021-08-04 22:17 ` [PATCH v2 1/2] protocol: add protocol version formatting function Josh Steadmon
2021-08-04 23:32 ` Ævar Arnfjörð Bjarmason
2021-08-04 22:17 ` [PATCH v2 2/2] connect, protocol: log negotiated protocol version Josh Steadmon
2021-08-04 22:28 ` Eric Sunshine
2021-08-06 21:15 ` Josh Steadmon
2021-08-04 23:40 ` Ævar Arnfjörð Bjarmason
2021-08-05 1:26 ` Taylor Blau
2021-08-05 2:47 ` Ævar Arnfjörð Bjarmason
2021-08-06 21:22 ` Josh Steadmon
2021-08-10 17:20 ` [PATCH v3] " Josh Steadmon
2021-08-16 18:03 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1628115064.git.steadmon@google.com \
--to=steadmon@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).