From: Josh Steadmon <steadmon@google.com>
To: git@vger.kernel.org, gitster@pobox.com, me@ttaylorr.com
Subject: [PATCH v2 1/2] protocol: add protocol version formatting function
Date: Wed, 4 Aug 2021 15:17:08 -0700 [thread overview]
Message-ID: <63f98062788a7c5d44fafecfde78077bdce2af73.1628115065.git.steadmon@google.com> (raw)
In-Reply-To: <cover.1628115064.git.steadmon@google.com>
Add a function to get human-readable names for the various wire protocol
versions.
Signed-off-by: Josh Steadmon <steadmon@google.com>
---
protocol.c | 14 ++++++++++++++
protocol.h | 6 ++++++
2 files changed, 20 insertions(+)
diff --git a/protocol.c b/protocol.c
index 052d7edbb9..7ec7ce896e 100644
--- a/protocol.c
+++ b/protocol.c
@@ -14,6 +14,20 @@ static enum protocol_version parse_protocol_version(const char *value)
return protocol_unknown_version;
}
+const char *format_protocol_version(enum protocol_version version)
+{
+ switch (version) {
+ case protocol_v0:
+ return "0";
+ case protocol_v1:
+ return "1";
+ case protocol_v2:
+ return "2";
+ default:
+ return "UNKNOWN_VERSION";
+ }
+}
+
enum protocol_version get_protocol_version_config(void)
{
const char *value;
diff --git a/protocol.h b/protocol.h
index cef1a4a01c..22e7a70912 100644
--- a/protocol.h
+++ b/protocol.h
@@ -8,6 +8,12 @@ enum protocol_version {
protocol_v2 = 2,
};
+/*
+ * Return a string representation for a given protocol version. Mainly used to
+ * handle protocol_unknown_version nicely.
+ */
+const char *format_protocol_version(enum protocol_version);
+
/*
* Used by a client to determine which protocol version to request be used when
* communicating with a server, reflecting the configured value of the
--
2.32.0.554.ge1b32706d8-goog
next prev parent reply other threads:[~2021-08-04 22:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 20:13 [PATCH] connect, protocol: log negotiated protocol version Josh Steadmon
2021-08-03 21:12 ` Taylor Blau
2021-08-04 21:37 ` Josh Steadmon
2021-08-04 21:56 ` Junio C Hamano
2021-08-04 22:17 ` [PATCH v2 0/2] " Josh Steadmon
2021-08-04 22:17 ` Josh Steadmon [this message]
2021-08-04 23:32 ` [PATCH v2 1/2] protocol: add protocol version formatting function Ævar Arnfjörð Bjarmason
2021-08-04 22:17 ` [PATCH v2 2/2] connect, protocol: log negotiated protocol version Josh Steadmon
2021-08-04 22:28 ` Eric Sunshine
2021-08-06 21:15 ` Josh Steadmon
2021-08-04 23:40 ` Ævar Arnfjörð Bjarmason
2021-08-05 1:26 ` Taylor Blau
2021-08-05 2:47 ` Ævar Arnfjörð Bjarmason
2021-08-06 21:22 ` Josh Steadmon
2021-08-10 17:20 ` [PATCH v3] " Josh Steadmon
2021-08-16 18:03 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f98062788a7c5d44fafecfde78077bdce2af73.1628115065.git.steadmon@google.com \
--to=steadmon@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).