From: Taylor Blau <firstname.lastname@example.org> To: email@example.com Cc: firstname.lastname@example.org, email@example.com Subject: [PATCH 0/3] commit-graph: introduce 'core.useBloomFilters' Date: Tue, 30 Jun 2020 13:17:36 -0400 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) Hi, Here are some patches that we have been using at GitHub to control whether or not Bloom filters stored in commit-graphs are read during normal operation. We're planning on using these patches as part of a two-phase roll-out of changed-path Bloom filters, where the first phase conditions whether or not repositories *write* Bloom filters, and the second phase (controlled via the new 'core.useBloomFilters') controls whether repositories *read* their Bloom filters. This can also be handy for debugging purposes, say, for e.g., if Bloom filters are suspected to be corrupt, they can be softly disabled without dropping the rest of the data in the commit-graph. Thanks in advance for your review. -Taylor Taylor Blau (3): commit-graph: pass a 'struct repository *' in more places t4216: fix broken '&&'-chain commit-graph: respect 'core.useBloomFilters' Documentation/config/core.txt | 5 +++++ builtin/commit-graph.c | 2 +- commit-graph.c | 17 ++++++++++------- commit-graph.h | 4 +++- fuzz-commit-graph.c | 5 +++-- repo-settings.c | 3 +++ repository.h | 1 + t/helper/test-read-graph.c | 3 ++- t/t4216-log-bloom.sh | 6 ++++-- 9 files changed, 32 insertions(+), 14 deletions(-) -- 18.104.22.168.g4cfa086e50
next reply other threads:[~2020-06-30 17:17 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-30 17:17 Taylor Blau [this message] 2020-06-30 17:17 ` [PATCH 1/3] commit-graph: pass a 'struct repository *' in more places Taylor Blau 2020-06-30 20:52 ` Derrick Stolee 2020-06-30 17:17 ` [PATCH 2/3] t4216: fix broken '&&'-chain Taylor Blau 2020-06-30 17:50 ` Eric Sunshine 2020-06-30 18:39 ` Taylor Blau 2020-06-30 19:03 ` Jeff King 2020-06-30 19:12 ` Taylor Blau 2020-06-30 19:19 ` Jeff King 2020-06-30 19:48 ` Eric Sunshine 2020-06-30 18:55 ` Jeff King 2020-06-30 17:17 ` [PATCH 3/3] commit-graph: respect 'core.useBloomFilters' Taylor Blau 2020-06-30 19:18 ` Jeff King 2020-06-30 19:27 ` Taylor Blau 2020-06-30 19:33 ` Jeff King 2020-08-03 19:02 ` [PATCH 0/3] commit-graph: introduce 'core.useBloomFilters' Taylor Blau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/3] commit-graph: introduce '\''core.useBloomFilters'\''' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).