From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 2/3] t4216: fix broken '&&'-chain
Date: Tue, 30 Jun 2020 15:19:41 -0400 [thread overview]
Message-ID: <20200630191941.GD1888406@coredump.intra.peff.net> (raw)
In-Reply-To: <20200630191231.GA30767@syl.lan>
On Tue, Jun 30, 2020 at 03:12:31PM -0400, Taylor Blau wrote:
> > I think so, but my argument would be more along the lines of:
> >
> > - without "-f", "rm" will complain about a missing file, which is
> > distracting noise in the test log
> >
> > - once "-f" is added in to suppress that, we might as well add the
> > command to the &&-chain. That's our normal style, so readers don't
> > have to wonder if it's important or not. Plus it would help avoid a
> > broken chain if more commands are added at the beginning of the
> > function.
>
> I made the change for basically these reasons, but mostly to bring this
> function into good style as with the rest of our test suite (there are a
> handful of other minor nits that we could look at, such as some odd
> spacing, etc.).
>
> Whether or not all of this needs to go into the commit message... I
> don't know. On the one hand, I think that your explanation here is
> clearer than what I wrote in the commit message, but on the other hand,
> I think that amending it again may be belaboring an otherwise simple
> change.
>
> If you feel strongly, though, I'm happy to send a revised patch.
I agree it's a pretty trivial patch, but I think if it's worth applying
at all, then it's worth justifying it appropriately.
-Peff
next prev parent reply other threads:[~2020-06-30 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 17:17 [PATCH 0/3] commit-graph: introduce 'core.useBloomFilters' Taylor Blau
2020-06-30 17:17 ` [PATCH 1/3] commit-graph: pass a 'struct repository *' in more places Taylor Blau
2020-06-30 20:52 ` Derrick Stolee
2020-06-30 17:17 ` [PATCH 2/3] t4216: fix broken '&&'-chain Taylor Blau
2020-06-30 17:50 ` Eric Sunshine
2020-06-30 18:39 ` Taylor Blau
2020-06-30 19:03 ` Jeff King
2020-06-30 19:12 ` Taylor Blau
2020-06-30 19:19 ` Jeff King [this message]
2020-06-30 19:48 ` Eric Sunshine
2020-06-30 18:55 ` Jeff King
2020-06-30 17:17 ` [PATCH 3/3] commit-graph: respect 'core.useBloomFilters' Taylor Blau
2020-06-30 19:18 ` Jeff King
2020-06-30 19:27 ` Taylor Blau
2020-06-30 19:33 ` Jeff King
2020-08-03 19:02 ` [PATCH 0/3] commit-graph: introduce 'core.useBloomFilters' Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630191941.GD1888406@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).