From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Brandon Williams <bmwill@google.com>,
Stefan Beller <sbeller@google.com>
Subject: [PATCH 0/2] Fix crashes due to real_pathdup() potentially returning NULL
Date: Wed, 8 Mar 2017 16:43:27 +0100 (CET) [thread overview]
Message-ID: <cover.1488987786.git.johannes.schindelin@gmx.de> (raw)
This problem was identified as the root cause for what seemed to be a
path conversion problem in the MSYS2 runtime at first glance.
Original bug report:
http://public-inbox.org/git/CAFKRc7y_kpCGNORENUZ2qw_4qBwjjyaaDFxAEQa52fTryj+w7A@mail.gmail.com/
We may want to consider fast-tracking this into v2.12.1, and to that
end, I would appreciate code reviews that focus on the correctness of
this patch and that try to consider undesired side effects.
Johannes Schindelin (2):
Demonstrate NULL pointer access with invalid GIT_WORK_TREE
Fix callsites of real_pathdup() that wanted it to die on error
abspath.c | 4 ++--
builtin/init-db.c | 6 +++---
cache.h | 2 +-
dir.c | 4 ++--
environment.c | 2 +-
setup.c | 4 ++--
submodule.c | 10 +++++-----
t/t1501-work-tree.sh | 8 ++++++++
worktree.c | 2 +-
9 files changed, 25 insertions(+), 17 deletions(-)
base-commit: e0688e9b28f2c5ff711460ee8b62077be5df2360
Published-As: https://github.com/dscho/git/releases/tag/real_pathdup-callers-v1
Fetch-It-Via: git fetch https://github.com/dscho/git real_pathdup-callers-v1
--
2.12.0.windows.1.7.g94dafc3b124
next reply other threads:[~2017-03-08 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 15:43 Johannes Schindelin [this message]
2017-03-08 15:43 ` [PATCH 1/2] Demonstrate NULL pointer access with invalid GIT_WORK_TREE Johannes Schindelin
2017-03-08 15:43 ` [PATCH 2/2] Fix callsites of real_pathdup() that wanted it to die on error Johannes Schindelin
2017-03-08 18:12 ` René Scharfe
2017-03-08 18:38 ` Brandon Williams
2017-03-08 21:16 ` Junio C Hamano
2017-03-09 11:24 ` Johannes Schindelin
2017-03-09 16:33 ` René Scharfe
2017-03-08 16:17 ` [PATCH 0/2] Fix crashes due to real_pathdup() potentially returning NULL Jeff King
2017-03-09 11:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1488987786.git.johannes.schindelin@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).