From: valtron <valtron2000@gmail.com>
To: git@vger.kernel.org
Subject: Crash on MSYS2 with GIT_WORK_TREE
Date: Tue, 7 Mar 2017 14:28:57 -0700 [thread overview]
Message-ID: <CAFKRc7y_kpCGNORENUZ2qw_4qBwjjyaaDFxAEQa52fTryj+w7A@mail.gmail.com> (raw)
Git 1.12.0. When GIT_WORK_TREE contains a drive-letter and
forward-slashes, some git commands crash:
C:\repo>set GIT_WORK_TREE=C:/repo
C:\repo>git rev-parse HEAD
1 [main] git 2332 cygwin_exception::open_stackdumpfile: Dumping
stack trace to git.exe.stackdump
C:\repo>set GIT_WORK_TREE=
C:\repo>git rev-parse HEAD
a394e40861e1012a96f9578a1f0cf0c5a49ede11
On the other hand, "C:\repo" and "/c/repo" don't have this issue.
Stacktrace from GDB (on git-rev-parse) is:
#0 0x000000018019634d in strcmp (s1=0x600062080 "/c/repo", s2=0x0)
at /msys_scripts/msys2-runtime/src/msys2-runtime/newlib/libc/string/strcmp.c:83
#1 0x00000001005239f1 in ?? ()
#2 0x0000000100523f36 in ?? ()
#3 0x000000010046c6fa in ?? ()
#4 0x0000000100401b6d in ?? ()
#5 0x0000000100401e4b in ?? ()
#6 0x0000000100563593 in ?? ()
#7 0x0000000180047c37 in _cygwin_exit_return ()
at /msys_scripts/msys2-runtime/src/msys2-runtime/winsup/cygwin/dcrt0.cc:1031
#8 0x0000000180045873 in _cygtls::call2 (this=0xffffce00,
func=0x180046bd0 <dll_crt0_1(void*)>, arg=0x0,
buf=buf@entry=0xffffcdf0) at
/msys_scripts/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:40
#9 0x0000000180045924 in _cygtls::call (func=<optimized out>,
arg=<optimized out>)
at /msys_scripts/msys2-runtime/src/msys2-runtime/winsup/cygwin/cygtls.cc:27
#10 0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
It seems "C:/repo" was changed to "/c/repo", but it crashes because it
gets compared to a nullptr.
next reply other threads:[~2017-03-07 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 21:28 valtron [this message]
2017-03-07 23:03 ` Crash on MSYS2 with GIT_WORK_TREE Johannes Schindelin
2017-03-08 0:51 ` Johannes Schindelin
2017-03-08 1:08 ` valtron
2017-03-08 12:03 ` Johannes Schindelin
2017-03-08 2:09 ` Brandon Williams
2017-03-08 11:59 ` Johannes Schindelin
2017-03-08 18:46 ` Brandon Williams
2017-03-08 22:19 ` Junio C Hamano
2017-03-08 2:36 ` Junio C Hamano
[not found] ` <xmqqa88w4bbp.fsf@gitster.mtv.corp.google.com>
2017-03-08 15:34 ` Johannes Schindelin
2017-03-08 17:24 ` Junio C Hamano
2017-03-08 1:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFKRc7y_kpCGNORENUZ2qw_4qBwjjyaaDFxAEQa52fTryj+w7A@mail.gmail.com \
--to=valtron2000@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).