git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Sixt" <j6t@kdbg.org>,
	"David Turner" <novalis@novalis.org>, "Jeff King" <peff@peff.net>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v2 0/6] Improve test coverage of update-ref error messages
Date: Fri, 10 Jun 2016 10:14:43 +0200	[thread overview]
Message-ID: <cover.1465544913.git.mhagger@alum.mit.edu> (raw)

This is v2 of the patch series. Thanks to Johannes Sixt and Junio for
their comments about v1 [1].

Changes since v1:

* In t1404, don't use non-portable `local`: change function
  test_update_rejected to refer to the global `$prefix` variable
  rather than taking it as a parameter.

* Because that code change has become more involved, split off the
  addition of documentation for the function into a separate patch.

These patches are also available from my GitHub account [2] as branch
update-ref-errors.

Michael

[1] http://thread.gmane.org/gmane.comp.version-control.git/296626
[2] https://github.com/mhagger/git

Michael Haggerty (6):
  t1404: rename file to t1404-update-ref-errors.sh
  t1404: remove "prefix" argument to test_update_rejected
  t1404: document function test_update_rejected
  t1404: add more tests of update-ref error handling
  lock_ref_for_update(): make error handling more uniform
  lock_ref_for_update(): avoid a symref resolution

 refs/files-backend.c               |  77 ++++---
 t/t1404-update-ref-df-conflicts.sh | 181 -----------------
 t/t1404-update-ref-errors.sh       | 407 +++++++++++++++++++++++++++++++++++++
 3 files changed, 452 insertions(+), 213 deletions(-)
 delete mode 100755 t/t1404-update-ref-df-conflicts.sh
 create mode 100755 t/t1404-update-ref-errors.sh

-- 
2.8.1

             reply	other threads:[~2016-06-10  8:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10  8:14 Michael Haggerty [this message]
2016-06-10  8:14 ` [PATCH v2 1/6] t1404: rename file to t1404-update-ref-errors.sh Michael Haggerty
2016-06-10  8:14 ` [PATCH v2 2/6] t1404: remove "prefix" argument to test_update_rejected Michael Haggerty
2016-06-10  8:14 ` [PATCH v2 3/6] t1404: document function test_update_rejected Michael Haggerty
2016-06-10  8:14 ` [PATCH v2 4/6] t1404: add more tests of update-ref error handling Michael Haggerty
2016-06-10  8:14 ` [PATCH v2 5/6] lock_ref_for_update(): make error handling more uniform Michael Haggerty
2016-06-10 19:01   ` David Turner
2016-06-13  7:16     ` Michael Haggerty
2016-06-13 10:10       ` Michael Haggerty
2016-06-10  8:14 ` [PATCH v2 6/6] lock_ref_for_update(): avoid a symref resolution Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1465544913.git.mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=novalis@novalis.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).