From: David Turner <novalis@novalis.org>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Johannes Sixt" <j6t@kdbg.org>, "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 5/6] lock_ref_for_update(): make error handling more uniform
Date: Fri, 10 Jun 2016 15:01:19 -0400 [thread overview]
Message-ID: <1465585279.8278.2.camel@frank> (raw)
In-Reply-To: <6cc13da6767c5fd9dbf1b372634adf7c3a353464.1465544913.git.mhagger@alum.mit.edu>
On Fri, 2016-06-10 at 10:14 +0200, Michael Haggerty wrote:
> /*
> + * Check whether the REF_HAVE_OLD and old_oid values stored in update
> + * are consistent with the result read for the reference. error is
> + * true iff there was an error reading the reference; otherwise, oid
"error" is not a thing here?
next prev parent reply other threads:[~2016-06-10 19:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 8:14 [PATCH v2 0/6] Improve test coverage of update-ref error messages Michael Haggerty
2016-06-10 8:14 ` [PATCH v2 1/6] t1404: rename file to t1404-update-ref-errors.sh Michael Haggerty
2016-06-10 8:14 ` [PATCH v2 2/6] t1404: remove "prefix" argument to test_update_rejected Michael Haggerty
2016-06-10 8:14 ` [PATCH v2 3/6] t1404: document function test_update_rejected Michael Haggerty
2016-06-10 8:14 ` [PATCH v2 4/6] t1404: add more tests of update-ref error handling Michael Haggerty
2016-06-10 8:14 ` [PATCH v2 5/6] lock_ref_for_update(): make error handling more uniform Michael Haggerty
2016-06-10 19:01 ` David Turner [this message]
2016-06-13 7:16 ` Michael Haggerty
2016-06-13 10:10 ` Michael Haggerty
2016-06-10 8:14 ` [PATCH v2 6/6] lock_ref_for_update(): avoid a symref resolution Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465585279.8278.2.camel@frank \
--to=novalis@novalis.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).