git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Björn Gustavsson" <bgustavsson@gmail.com>,
	git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH 0/4] Fix handling of remotes with single-character names
Date: Tue, 28 Jul 2015 23:08:17 +0200	[thread overview]
Message-ID: <cover.1438117334.git.mhagger@alum.mit.edu> (raw)

The parsing of `remotes.<groupname>` was broken if any of the remotes
in the group has a name consisting of a single character.

The first patch fixes the bug; the others are general refactoring to
make the function a little bit clearer.

This series is based on maint, which I just noticed is still v2.4.7,
but it also rebases cleanly to master. It might make sense to apply
only the first patch to maint and the others only to master.

These patches are also available from my GitHub repository [1] as
branch "single-character-remotes".

Michael

[1] https://github.com/mhagger/git

Michael Haggerty (4):
  get_remote_group(): handle remotes with single-character names
  get_remote_group(): rename local variable "space" to "wordlen"
  get_remote_group(): eliminate superfluous call to strcspn()
  get_remote_group(): use skip_prefix()

 builtin/fetch.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

-- 
2.4.6

             reply	other threads:[~2015-07-28 21:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 21:08 Michael Haggerty [this message]
2015-07-28 21:08 ` [PATCH 1/4] get_remote_group(): handle remotes with single-character names Michael Haggerty
2015-07-28 21:08 ` [PATCH 2/4] get_remote_group(): rename local variable "space" to "wordlen" Michael Haggerty
2015-07-28 21:08 ` [PATCH 3/4] get_remote_group(): eliminate superfluous call to strcspn() Michael Haggerty
2015-07-28 21:08 ` [PATCH 4/4] get_remote_group(): use skip_prefix() Michael Haggerty
2015-07-30 22:12 ` [PATCH 0/4] Fix handling of remotes with single-character names Junio C Hamano
2015-07-31 15:01   ` Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1438117334.git.mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=bgustavsson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).