From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Björn Gustavsson" <bgustavsson@gmail.com>,
git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH 3/4] get_remote_group(): eliminate superfluous call to strcspn()
Date: Tue, 28 Jul 2015 23:08:20 +0200 [thread overview]
Message-ID: <441622b3d894ab73de159d55176f485d7c56b147.1438117334.git.mhagger@alum.mit.edu> (raw)
In-Reply-To: <cover.1438117334.git.mhagger@alum.mit.edu>
There is no need to call it if value is the empty string. This also
eliminates code duplication.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
builtin/fetch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index d0d267b..bd945d0 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -978,13 +978,13 @@ static int get_remote_group(const char *key, const char *value, void *priv)
if (starts_with(key, "remotes.") &&
!strcmp(key + 8, g->name)) {
/* split list by white space */
- size_t wordlen = strcspn(value, " \t\n");
while (*value) {
+ size_t wordlen = strcspn(value, " \t\n");
+
if (wordlen >= 1)
string_list_append(g->list,
xstrndup(value, wordlen));
value += wordlen + (value[wordlen] != '\0');
- wordlen = strcspn(value, " \t\n");
}
}
--
2.4.6
next prev parent reply other threads:[~2015-07-28 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 21:08 [PATCH 0/4] Fix handling of remotes with single-character names Michael Haggerty
2015-07-28 21:08 ` [PATCH 1/4] get_remote_group(): handle " Michael Haggerty
2015-07-28 21:08 ` [PATCH 2/4] get_remote_group(): rename local variable "space" to "wordlen" Michael Haggerty
2015-07-28 21:08 ` Michael Haggerty [this message]
2015-07-28 21:08 ` [PATCH 4/4] get_remote_group(): use skip_prefix() Michael Haggerty
2015-07-30 22:12 ` [PATCH 0/4] Fix handling of remotes with single-character names Junio C Hamano
2015-07-31 15:01 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441622b3d894ab73de159d55176f485d7c56b147.1438117334.git.mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=bgustavsson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).