From: "René Scharfe" <l.s.r@web.de>
To: Duy Nguyen <pclouds@gmail.com>, Jeff King <peff@peff.net>
Cc: Christian Couder <christian.couder@gmail.com>,
Thomas Gummerer <t.gummerer@gmail.com>, git <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] cache-tree: reject entries with null sha1
Date: Wed, 3 May 2017 21:48:31 +0200 [thread overview]
Message-ID: <cddd09e5-8e8a-3dc9-001f-f307d3647619@web.de> (raw)
In-Reply-To: <CACsJy8CdjLySD+UEKE2NkbYqEoVOQtvydFBui6UbbnFLo8U1Ug@mail.gmail.com>
Am 03.05.2017 um 11:46 schrieb Duy Nguyen:
> On Tue, May 2, 2017 at 2:22 AM, Jeff King <peff@peff.net> wrote:
>> On Mon, May 01, 2017 at 01:23:28PM +0200, René Scharfe wrote:
>>>
>>> I can only get gcc and clang to call memcpy instead of inlining it by
>>> specifying -fno-builtin. Do you use that option? If yes, why? (Just
>>> curious.)
>>
>> I do my normal edit-compile cycles with -O0 because it's fast, and
>> because it makes debugging much easier.
>
> Same here. My CFLAGS (without lots of -Wstuff)
>
> CFLAGS = -g -O0 -fstack-protector
>
> Maybe it's -fstack-protector then? This is gcc 4.9.3. I think Gentoo
> does not add any distro-specific patches on this particular version.
gcc 4.9.2 on Debian i386 still inlines memcpy for me with these options.
https://packages.debian.org/jessie/gcc-4.9 links to a 5MB diff, and it
adds these lines to NEWS.gcc (plus changing a whole lot of other files,
of course):
+ - Better inlining of memcpy and memset that is aware of value ranges
+ and produces shorter alignment prologues.
That might be it.
René
prev parent reply other threads:[~2017-05-03 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 18:46 [PATCH] cache-tree: reject entries with null sha1 Jeff King
2017-04-24 10:39 ` Duy Nguyen
2017-04-24 11:13 ` Jeff King
2017-05-01 11:23 ` René Scharfe
2017-05-01 11:55 ` René Scharfe
2017-05-01 19:22 ` Jeff King
2017-05-01 21:00 ` René Scharfe
2017-05-01 21:26 ` Jeff King
2017-05-03 9:46 ` Duy Nguyen
2017-05-03 19:48 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cddd09e5-8e8a-3dc9-001f-f307d3647619@web.de \
--to=l.s.r@web.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).