From: Duy Nguyen <pclouds@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>,
"Christian Couder" <christian.couder@gmail.com>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
git <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] cache-tree: reject entries with null sha1
Date: Wed, 3 May 2017 16:46:04 +0700 [thread overview]
Message-ID: <CACsJy8CdjLySD+UEKE2NkbYqEoVOQtvydFBui6UbbnFLo8U1Ug@mail.gmail.com> (raw)
In-Reply-To: <20170501192212.xy5o72tinb2hy2a3@sigill.intra.peff.net>
On Tue, May 2, 2017 at 2:22 AM, Jeff King <peff@peff.net> wrote:
> On Mon, May 01, 2017 at 01:23:28PM +0200, René Scharfe wrote:
>
>> Am 24.04.2017 um 12:39 schrieb Duy Nguyen:
>> > BTW, I ran t7009 with valgrind and it reported this. Is it something
>> > we should be worried about? I vaguely recall you're doing something
>> > with prio-queue...
>> >
>> > ==4246== Source and destination overlap in memcpy(0x5952990, 0x5952990, 16)
>> > ==4246== at 0x4C2EACD: memcpy@@GLIBC_2.14 (in
>> > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>> > ==4246== by 0x545D05: swap (prio-queue.c:15)
>> > ==4246== by 0x545D72: prio_queue_reverse (prio-queue.c:25)
>> > ==4246== by 0x4CBC0C: sort_in_topological_order (commit.c:723)
>> > ==4246== by 0x574C97: prepare_revision_walk (revision.c:2858)
>> > ==4246== by 0x48A2BA: cmd_rev_list (rev-list.c:385)
>> > ==4246== by 0x405A6F: run_builtin (git.c:371)
>> > ==4246== by 0x405CDC: handle_builtin (git.c:572)
>> > ==4246== by 0x405E51: run_argv (git.c:624)
>> > ==4246== by 0x405FF3: cmd_main (git.c:701)
>> > ==4246== by 0x4A48CE: main (common-main.c:43)
>>
>> I can only get gcc and clang to call memcpy instead of inlining it by
>> specifying -fno-builtin. Do you use that option? If yes, why? (Just
>> curious.)
>
> I do my normal edit-compile cycles with -O0 because it's fast, and
> because it makes debugging much easier.
Same here. My CFLAGS (without lots of -Wstuff)
CFLAGS = -g -O0 -fstack-protector
Maybe it's -fstack-protector then? This is gcc 4.9.3. I think Gentoo
does not add any distro-specific patches on this particular version.
--
Duy
next prev parent reply other threads:[~2017-05-03 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 18:46 [PATCH] cache-tree: reject entries with null sha1 Jeff King
2017-04-24 10:39 ` Duy Nguyen
2017-04-24 11:13 ` Jeff King
2017-05-01 11:23 ` René Scharfe
2017-05-01 11:55 ` René Scharfe
2017-05-01 19:22 ` Jeff King
2017-05-01 21:00 ` René Scharfe
2017-05-01 21:26 ` Jeff King
2017-05-03 9:46 ` Duy Nguyen [this message]
2017-05-03 19:48 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8CdjLySD+UEKE2NkbYqEoVOQtvydFBui6UbbnFLo8U1Ug@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).