From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv6 8/8] gitweb: add avatar in signoff lines
Date: Sat, 27 Jun 2009 12:21:29 +0200 [thread overview]
Message-ID: <cb7bb73a0906270321m6154e6a2l240723ffbd7b6e8f@mail.gmail.com> (raw)
In-Reply-To: <200906271126.38757.jnareb@gmail.com>
2009/6/27 Jakub Narebski <jnareb@gmail.com>:
> On Thu, 25 June 2009, Giuseppe Bilotta wrote:
>
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> BTW. if it is an RFC, it should be marked as RFC in subject
> ("[RFC PATCHv6 8/8] gitweb: add avatar in signoff lines").
>
> And I guess this issue should be left for later.
You're right. My next patchset will not include this part (I'll send
it separately).
>> I can't say I'm really satisfied with the layout given by this patch.
>> A significant improvement could be obtained by turning the signoff
>> line block into a table with three/four columns (signoff, name,
>> email/avatar).
>
> First, I think adding (gr)avatars to signoff lines might be not worth
> it. Neither GitHub nor Gitorious show gravatars for signoff lines
> (note that they use larger images, and therefore easier to view).
Well, just because the others don't do it, it doesn't mean we
shouldn't either ;-)
But yes, I have to confess I love toying around like this.
> Second, it is not the only possible layout. Let's use one of existing
> commits (e1d3793) in git repository as example:
>
> completion: add --thread=deep/shallow to format-patch
>
> [1] Signed-off-by: Stephen Boyd <bebarino@gmail.com> [2] [3] [4]|
> [1] Trivially-Acked-By: Shawn O. Pearce <spearce@spearce.org> [2] [3] [4]|
> [1] Signed-off-by: Junio C Hamano <gitster@pobox.com> [2] [3] [4]|
>
> Even without changing layout of signoff lines (so they look exactly
> like they look in git-show or git-log output, modulo highlighting
> and (gr)avatars), there are more possibilities:
>
> 1. On the left side of signoff lines
> 2. Current version: on the right side of signoff lines, just after
> 3. On the right hand side, aligned; would probably need table
> 4. On the right hand side, flushed (floated) right
I have a table implementation running @ http://git.oblomov.eu/git/commit/e1d3793
> There is also more complicated solution of having (gr)avatars appear
> only on mouseover, either all avatars on hover over signoff block,
> or single (and perhaps larger size) avatar on hover over signoff line.
> This can be done using pure CSS, without JavaScript[1]
>
> [1] http://meyerweb.com/eric/css/edge/popups/demo2.html
Oh, that'd be an interesting variant. Straightforward to implement in
the table case, too.
> And here is version with (gr)avatar on the left side of signoff lines
> (take a look if it is not better layout):
>
> diff --git c/gitweb/gitweb.perl w/gitweb/gitweb.perl
> index 301bdd8..7701bac 100755
> --- c/gitweb/gitweb.perl
> +++ w/gitweb/gitweb.perl
> @@ -3407,6 +3407,8 @@ sub git_print_log {
> $signoff = 1;
> $empty = 0;
> if (! $opts{'-remove_signoff'}) {
> + my ($email) = $line =~ /<(\S+@\S+)>/;
> + print git_get_avatar($email, 'pad_after' => 1) if $email;
> print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
> next;
> } else {
I think that putting them aligned on the right is somewhat better
because both in commit(diff) and in log view the author/committer
avatar is already on the right.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-06-27 10:23 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 10:42 [PATCHv6 0/8] gitweb: gravatar support Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 1/8] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 2/8] gitweb: uniform author info for commit and commitdiff Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 3/8] gitweb: right-align date cell in shortlog Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 4/8] gitweb: (gr)avatar support Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 5/8] gitweb: gravatar url cache Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 6/8] gitweb: add 'alt' to avatar images Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 7/8] gitweb: recognize 'trivial' acks Giuseppe Bilotta
2009-06-25 10:43 ` [PATCHv6 8/8] gitweb: add avatar in signoff lines Giuseppe Bilotta
2009-06-25 13:21 ` [PATCHv6 9/8] gitweb: put signoff lines in a table Giuseppe Bilotta
2009-06-27 9:55 ` Jakub Narebski
2009-06-27 9:26 ` [PATCHv6 8/8] gitweb: add avatar in signoff lines Jakub Narebski
2009-06-27 10:21 ` Giuseppe Bilotta [this message]
2009-06-27 0:19 ` [PATCHv6 7/8] gitweb: recognize 'trivial' acks Jakub Narebski
2009-06-27 1:03 ` Junio C Hamano
2009-06-27 9:04 ` Giuseppe Bilotta
2009-06-26 23:39 ` [PATCHv6 6/8] gitweb: add 'alt' to avatar images Jakub Narebski
2009-06-27 0:08 ` Thomas Adam
2009-06-26 23:11 ` [PATCHv6 5/8] gitweb: gravatar url cache Jakub Narebski
2009-06-26 23:27 ` Giuseppe Bilotta
2009-06-26 23:53 ` Jakub Narebski
2009-06-26 19:42 ` [PATCHv6 4/8] gitweb: (gr)avatar support Jakub Narebski
2009-06-26 22:08 ` Giuseppe Bilotta
2009-06-26 22:58 ` Jakub Narebski
2009-06-26 23:14 ` Giuseppe Bilotta
2009-06-26 23:25 ` Jakub Narebski
2009-06-27 0:29 ` Junio C Hamano
2009-06-27 0:32 ` Giuseppe Bilotta
2009-06-26 9:33 ` [PATCHv6 3/8] gitweb: right-align date cell in shortlog Jakub Narebski
2009-06-26 18:06 ` Giuseppe Bilotta
2009-06-26 22:34 ` Junio C Hamano
2009-06-26 22:57 ` Giuseppe Bilotta
2009-06-26 23:57 ` Junio C Hamano
2009-06-27 12:14 ` Jakub Narebski
2009-06-27 12:49 ` Jakub Narebski
2009-06-25 23:14 ` [PATCHv6 2/8] gitweb: uniform author info for commit and commitdiff Jakub Narebski
2009-06-26 17:52 ` Giuseppe Bilotta
2009-06-25 22:55 ` [PATCHv6 1/8] gitweb: refactor author name insertion Jakub Narebski
2009-06-25 23:01 ` Jakub Narebski
2009-06-25 23:41 ` Giuseppe Bilotta
2009-06-25 12:55 ` [PATCHv6 0/8] gitweb: gravatar support Jakub Narebski
2009-06-25 13:15 ` Giuseppe Bilotta
2009-06-25 17:07 ` Junio C Hamano
2009-06-25 18:46 ` Giuseppe Bilotta
2009-06-25 18:56 ` Junio C Hamano
2009-06-25 23:17 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0906270321m6154e6a2l240723ffbd7b6e8f@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).