Re: [PATCHv6 3/8] gitweb: right-align date cell in shortlog

[Giuseppe Bilotta <giuseppe.bilotta@gmail.com>]

2009/6/26 Jakub Narebski <jnareb@gmail.com>:
> On Thu, 25 June 2009, Giuseppe Bilotta wrote:
>
>> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
>> index 68b22ff..7240ed7 100644
>> --- a/gitweb/gitweb.css
>> +++ b/gitweb/gitweb.css
>> @@ -180,6 +180,10 @@ table {
>
>> +table.shortlog td:first-child{
>> +     text-align: right;
>> +}
>
> First, there is no space between ':first-child' pseudo-class selector
> and opening '{'.  It should be "td:first-child {".

Right.

> Second, I'd rather avoid more advanced CSS constructs; not all web
> browsers support ':first-child' selector.  On the other hand adding
> class attribute to handle this would make page slightly larger.

IIRC :first-child is supported from IE7 onwards. There are hacks to
make it work on IE6, but I think they are definitely not worth it.

> Last, and most important: I don't agree with this change.  In my
> opinion it does not improve layout (and you didn't provide support
> for this change).  Right-align justification should be sparingly,
> as it is not natural in left-to-right languages.

Of course, in my opinion it does improve layout.

The effect is to right-laign the first column of shortlog view, i.e.
the one holding the date. For dates that are presented as yyyy-mm-dd
it makes not difference, but when the phrasing is 'X days ago' it
provides the benefit of aligning the 'days ago' part instead of having
it ragged. See it live at

http://git.oblomov.eu/git/shortlog

and judge for yourselves.

-- 
Giuseppe "Oblomov" Bilotta