From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)
Date: Tue, 20 Dec 2022 23:59:32 +0100 (CET) [thread overview]
Message-ID: <c57ecd23-7ca7-2501-983f-6661c7872a01@gmx.de> (raw)
In-Reply-To: <xmqqa63ss3fl.fsf@gitster.g>
Hi Junio,
On Tue, 13 Dec 2022, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > There is a new iteration available here:
> > https://lore.kernel.org/git/pull.1309.v5.git.1670339267.gitgitgadget@gmail.com/
>
> Thanks.
>
> IIRC the review comments hinted that MinGW specific test_cmp that
> equates CRLF and LF are no longer needed,
That does not match my understanding. The MSYS2 tools we use in Git for
Windows' SDK (and therefore, in the `win` jobs of our CI runs) are outside
of our control, and have been known to change behavior with regards to
line endings.
If we want to have a robust experience, we will need to continue that
`test_cmp` practice that ignores line endings-only differences.
Ciao,
Johannes
next prev parent reply other threads:[~2022-12-20 23:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 5:18 What's cooking in git.git (Dec 2022, #03; Sun, 11) Junio C Hamano
2022-12-12 7:50 ` js/drop-mingw-test-cmp, was " Johannes Schindelin
2022-12-12 21:43 ` Junio C Hamano
2022-12-20 22:59 ` Johannes Schindelin [this message]
2022-12-21 13:05 ` Junio C Hamano
2022-12-24 8:10 ` Johannes Sixt
2022-12-24 13:31 ` René Scharfe
2022-12-25 14:45 ` Junio C Hamano
2022-12-25 15:44 ` Johannes Sixt
2022-12-26 19:53 ` René Scharfe
2022-12-27 12:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c57ecd23-7ca7-2501-983f-6661c7872a01@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).