git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)
Date: Sat, 24 Dec 2022 09:10:08 +0100	[thread overview]
Message-ID: <3c55ac67-5090-b7af-a212-2996bad66fb2@kdbg.org> (raw)
In-Reply-To: <xmqq7cyksy88.fsf@gitster.g>

Am 21.12.22 um 14:05 schrieb Junio C Hamano:
> I know we have been operating under such a test environment, but
> after seeing the exchange between Réne and J6t, I was hoping that we
> do not have to keep being sloppy.

Things did not turn out to be as simple. After ripping out all
special-casing of GIT_TEST_CMP from a MinGW build, I notice at least one
case that needs special treatment (it's `tar tf` that writes CRLF
output). On top of that, there are prerequisites SED_STRIPS_CR,
GREP_STRIPS_CR and perhaps NATIVE_CRLF that should be reconsidered.

For the time being, I suggest to take Dscho's patch.

-- Hannes


  reply	other threads:[~2022-12-24  8:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  5:18 What's cooking in git.git (Dec 2022, #03; Sun, 11) Junio C Hamano
2022-12-12  7:50 ` js/drop-mingw-test-cmp, was " Johannes Schindelin
2022-12-12 21:43   ` Junio C Hamano
2022-12-20 22:59     ` Johannes Schindelin
2022-12-21 13:05       ` Junio C Hamano
2022-12-24  8:10         ` Johannes Sixt [this message]
2022-12-24 13:31           ` René Scharfe
2022-12-25 14:45             ` Junio C Hamano
2022-12-25 15:44             ` Johannes Sixt
2022-12-26 19:53               ` René Scharfe
2022-12-27 12:52                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c55ac67-5090-b7af-a212-2996bad66fb2@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).