git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, stolee@gmail.com
Subject: [PATCH 1/2] t5616: use correct flag to check object is missing
Date: Tue, 11 Jun 2019 14:06:46 -0700	[thread overview]
Message-ID: <c09d6119e51d70390d130cd9c47ef8d363244f80.1560286956.git.jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1560286956.git.jonathantanmy@google.com>

If we want to check whether an object is missing, the correct flag to
pass to rev-list is --ignore-missing; --exclude-promisor-objects will
exclude any object that came from the promisor remote, whether it is
present or missing. Use the correct flag.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
 t/t5616-partial-clone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
index f1baf83502..8b9b471a62 100755
--- a/t/t5616-partial-clone.sh
+++ b/t/t5616-partial-clone.sh
@@ -359,7 +359,7 @@ test_expect_success 'tolerate server sending REF_DELTA against missing promisor
 		--filter=blob:none $HTTPD_URL/one_time_sed/server repo &&
 
 	# Sanity check to ensure that the client does not have that blob.
-	git -C repo rev-list --objects --exclude-promisor-objects \
+	git -C repo rev-list --objects --ignore-missing \
 		-- $(cat deltabase) >objlist &&
 	test_line_count = 0 objlist &&
 
-- 
2.22.0.rc2.383.gf4fbbf30c2-goog


  reply	other threads:[~2019-06-11 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 21:06 [PATCH 0/2] Improve test code coverage on jt/partial-clone-missing-ref-delta-base Jonathan Tan
2019-06-11 21:06 ` Jonathan Tan [this message]
2019-06-11 21:06 ` [PATCH 2/2] t5616: cover case of client having delta base Jonathan Tan
2019-06-12  2:39 ` [PATCH 0/2] Improve test code coverage on jt/partial-clone-missing-ref-delta-base Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c09d6119e51d70390d130cd9c47ef8d363244f80.1560286956.git.jonathantanmy@google.com \
    --to=jonathantanmy@google.com \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).