From: Derrick Stolee <stolee@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] Improve test code coverage on jt/partial-clone-missing-ref-delta-base
Date: Tue, 11 Jun 2019 22:39:26 -0400 [thread overview]
Message-ID: <464f2cb0-68a5-ec2b-e526-98874c27a8b4@gmail.com> (raw)
In-Reply-To: <cover.1560286956.git.jonathantanmy@google.com>
On 6/11/2019 5:06 PM, Jonathan Tan wrote:
> This series is on jt/partial-clone-missing-ref-delta-base.
>
> Patch 1 is a cleanup, and patch 2 improves test code coverage. Thanks to
> Stolee for the code coverage report.
>
> I have checked this by running `make coverage` then `make cover_db_html`
> on both "next" and this series, and comparing the output - the
> relevant line indeed shows up as uncovered on "next", and covered on
> this.
Thanks for the additional tests, Jonathan! The update in PATCH 2 looks
like it took a bit of work, so thanks for your efforts there!
LGTM.
-Stolee
prev parent reply other threads:[~2019-06-12 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 21:06 [PATCH 0/2] Improve test code coverage on jt/partial-clone-missing-ref-delta-base Jonathan Tan
2019-06-11 21:06 ` [PATCH 1/2] t5616: use correct flag to check object is missing Jonathan Tan
2019-06-11 21:06 ` [PATCH 2/2] t5616: cover case of client having delta base Jonathan Tan
2019-06-12 2:39 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464f2cb0-68a5-ec2b-e526-98874c27a8b4@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).