From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Han-Wen Nienhuys" <hanwen@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))
Date: Fri, 20 Aug 2021 23:08:20 +0100 [thread overview]
Message-ID: <bc387e32-321e-4726-2a02-2e6cf6ed5250@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqtujkwsu0.fsf@gitster.g>
On 20/08/2021 07:09, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> * hn/reftable (2021-08-16) 25 commits
>> - t1404: annotate test cases with REFFILES
>> ...
>> - hash.h: provide constants for the hash IDs
>>
>> The "reftable" backend for the refs API.
>
> As discussed in the thread that leads to [*1*], this topic has been
> blocked by the "clean-up errno use in the refs subsystem" topic for
> too long. I think it deserves to have its own chance to be looked
> at by more eyes.
>
> I've reverted the three topics around "errno" out of 'next', while
> rebasing them into a single strand of pearls, and queued them near
> the tip of 'seen'. The hn/reftable topic is merged into 'seen'
> earlier then these "errno" topics.
Just a gentle reminder that this topic tickles my 'static-check.pl'
script, like so:
$ diff nsc ssc
...
88a91,98
> reftable/generic.o - reftable_table_seek_log
> reftable/merged.o - reftable_merged_table_hash_id
> reftable/merged.o - reftable_merged_table_min_update_index
> reftable/merged.o - reftable_merged_table_seek_log_at
> reftable/publicbasics.o - reftable_set_alloc
> reftable/reader.o - reader_seek
> reftable/reader.o - reftable_reader_seek_log_at
> reftable/stack.o - reftable_stack_auto_compact
...
$
Which is to say, all of the above symbols are defined (and called) in
the '.c' file corresponding to the given object file, but not called
anywhere outside that file. I have not even looked at those functions,
but (with the possible exception of reftable_set_alloc()) they don't
strike me as 'public API functions'. So, maybe they should be marked
as 'static'?
ATB,
Ramsay Jones
next prev parent reply other threads:[~2021-08-20 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
2021-08-16 23:43 ` Azeem Bande-Ali
2021-08-17 16:39 ` Junio C Hamano
2021-08-17 10:20 ` Phillip Wood
2021-08-17 16:47 ` Junio C Hamano
2021-08-17 17:12 ` Derrick Stolee
2021-08-18 5:15 ` Eric Sunshine
2021-08-19 10:06 ` Phillip Wood
2021-08-17 17:00 ` Philippe Blain
2021-08-17 19:40 ` Junio C Hamano
2021-08-17 21:48 ` Junio C Hamano
2021-08-19 18:55 ` Phillip Wood
2021-08-19 19:38 ` Junio C Hamano
2021-08-20 6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
2021-08-20 22:08 ` Ramsay Jones [this message]
2021-10-07 17:27 ` Han-Wen Nienhuys
[not found] ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
2021-08-23 10:21 ` Ævar Arnfjörð Bjarmason
-- strict thread matches above, loose matches on Subject: below --
2021-08-21 8:17 Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc387e32-321e-4726-2a02-2e6cf6ed5250@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).