From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org, "Lénaïc Huard" <lenaic@lhuard.fr>
Subject: Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
Date: Tue, 17 Aug 2021 13:12:56 -0400 [thread overview]
Message-ID: <7a4b1238-5c3b-4c08-0e9d-511f857f9c38@gmail.com> (raw)
In-Reply-To: <xmqqh7fonhlo.fsf@gitster.g>
On 8/17/2021 12:47 PM, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
...
>>> * lh/systemd-timers (2021-07-02) 3 commits
>>> - maintenance: add support for systemd timers on Linux
>>> - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>>> - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>>> "git maintenance" scheduler learned to use systemd timers as a
>>> possible backend.
>>> Waiting for reviews.
>>
>> I'd really like to see this merged, there was some discussion a couple
>> of weeks ago (cf <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>), it
>> petered out but no one seemed to be objecting to merging it.
>
> Thanks for paying attention to this item.
>
> My impression was that everybody likes the ability to use systemd
> timers as an alternative to cron, but as Derrick summarised in the
> message you pointed at, I think the implementation is not quite
> there.
>
> So "Waiting for reviews" is a mislabel; we are waiting for a reroll.
I think a lot of our comments were "We would hold an established
contributor to a higher standard, but this is sufficient for a new
contributor. The rest can be forward-fixed." We also have not heard
from the original contributor since that discussion.
Perhaps enough time has passed that we can expect Lénaïc will not
get back to us, I could give an attempt to forward-fix the comments
with a patch series on top of these. We could then hold
lh/systemd-timers in 'next' (or even 'seen') until it can be joined
with those fixes.
If preferred, I could restart the series by inserting some patches
and editing some of the ones in the list currently.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-08-17 17:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
2021-08-16 23:43 ` Azeem Bande-Ali
2021-08-17 16:39 ` Junio C Hamano
2021-08-17 10:20 ` Phillip Wood
2021-08-17 16:47 ` Junio C Hamano
2021-08-17 17:12 ` Derrick Stolee [this message]
2021-08-18 5:15 ` Eric Sunshine
2021-08-19 10:06 ` Phillip Wood
2021-08-17 17:00 ` Philippe Blain
2021-08-17 19:40 ` Junio C Hamano
2021-08-17 21:48 ` Junio C Hamano
2021-08-19 18:55 ` Phillip Wood
2021-08-19 19:38 ` Junio C Hamano
2021-08-20 6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
2021-08-20 22:08 ` Ramsay Jones
2021-10-07 17:27 ` Han-Wen Nienhuys
[not found] ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
2021-08-23 10:21 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4b1238-5c3b-4c08-0e9d-511f857f9c38@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lenaic@lhuard.fr \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).