From: Derrick Stolee <stolee@gmail.com> To: "Martin Ågren" <martin.agren@gmail.com>, "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> Cc: "Git Mailing List" <git@vger.kernel.org>, "Jonathan Nieder" <jrnieder@gmail.com>, "Jonathan Tan" <jonathantanmy@google.com>, sluongng@gmail.com, "Đoàn Trần Công Danh" <congdanhqx@gmail.com>, "SZEDER Gábor" <szeder.dev@gmail.com>, "Derrick Stolee" <derrickstolee@github.com>, "Derrick Stolee" <dstolee@microsoft.com> Subject: Re: [PATCH v2 6/7] maintenance: recommended schedule in register/start Date: Wed, 30 Sep 2020 16:11:47 -0400 [thread overview] Message-ID: <bb9cd08f-1e59-ae19-b184-545688451203@gmail.com> (raw) In-Reply-To: <CAN0heSqkJoqXKP5ccaGMA1_ppd0bcQ7G0ozUH+H7tBMonhcrjQ@mail.gmail.com> On 9/29/2020 3:48 PM, Martin Ågren wrote: > Hi Stolee, > > On Fri, 11 Sep 2020 at 19:53, Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> If a user sets any 'maintenance.<task>.schedule' config value, then >> they have chosen a specific schedule for themselves and Git should >> respect that. >> >> However, in an effort to recommend a good schedule for repositories of >> all sizes, set new config values for recommended tasks that are safe to >> run in the background while users run foreground Git commands. These >> commands are generally everything but the 'gc' task. > > If there aren't any "schedule" configurations, we'll go ahead and > sprinkle in quite a few of them. I suppose that another approach would > be that later, much later, when we go look for these configuration > items, we could go "there is not a single one set, let's act as if > *these* were configured". I do like this alternative. > The advantage there would be that we can tweak those defaults over time. > Whereas with the approach of this patch, v2.29.0 will give the user a > snapshot of 2020's best practices. If they want to catch up, they will > need to drop all their "schedule" config and re-"register", or use a > future `git maintenance reregister`. ;-) This is a significant advantage! Great idea. It might be a bit difficult to slide this in, but I bet it would work out OK if we have a "initialize_schedule()" option that is only run when the "--schedule=<...>" option is given? The trickiest part is actually setting the ".enabled" configs to "true" as well. The condition for using the "default" schedule might get a bit complicated. I do think it is worth some effort to do, as adjusting defaults in code is certainly easier than modifying config values. > Anyway, this is a convenience thing. There's a chance that "convenience" > interferes with "perfect" and "optimal". I guess that's to be expected. > >> +If your repository has no 'maintenance.<task>.schedule' configuration > > Thank you for going above and beyond with marking config items et cetera > for rendering in `monospace`. I just noticed that this is slightly > mis-marked-upped. If you end up rerolling this patch series for some > reason, you might want to switch from 'single quotes' to `backticks` in > this particular instance. Thanks! Yeah that was a mis-type. > While I'm commenting anyway... > >> +static int has_schedule_config(void) >> +{ >> + int i, found = 0; >> + struct strbuf config_name = STRBUF_INIT; >> + size_t prefix; >> + >> + strbuf_addstr(&config_name, "maintenance."); >> + prefix = config_name.len; >> + >> + for (i = 0; !found && i < TASK__COUNT; i++) { >> + char *value; >> + >> + strbuf_setlen(&config_name, prefix); >> + strbuf_addf(&config_name, "%s.schedule", tasks[i].name); >> + >> + if (!git_config_get_string(config_name.buf, &value)) { >> + found = 1; >> + FREE_AND_NULL(value); >> + } >> + } >> + >> + strbuf_release(&config_name); >> + return found; >> +} > > That `FREE_AND_NULL()` caught me off-guard. The pointer is on the stack. > I suppose it doesn't *hurt*, but being careful to set it to NULL made me > go "huh". > > I suppose you could drop the `!found` check in favour of `break`-ing > precisely when you get a hit. > > And I do wonder how much the reuse of the "maintenance." part of the > buffer helps performance. All valid points. > In the end, you could use something like the following (not compiled): > > static int has_schedule_config(void) > { > int i, found = 0; > struct strbuf config_name = STRBUF_INIT; > > for (i = 0; i < TASK__COUNT; i++) { > const char *value; > > strbuf_reset(&config_name); > strbuf_addf(&config_name, "maintenance.%s.schedule", > tasks[i].name); > > if (!git_config_get_value(config_name.buf, &value)) { > found = 1; > break; > } > } > > strbuf_release(&config_name); > return found; > } > > Anyway, that's just microniting, obviously, but maybe in the sum it has > some value. Sounds good to me. I'll work on a new version that makes your recommendations. Thanks, -Stolee
next prev parent reply other threads:[~2020-09-30 20:11 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-04 15:41 [PATCH 0/7] Maintenance III: Background maintenance Derrick Stolee via GitGitGadget 2020-09-04 15:42 ` [PATCH 1/7] maintenance: optionally skip --auto process Derrick Stolee via GitGitGadget 2020-09-04 15:42 ` [PATCH 2/7] maintenance: add --schedule option and config Derrick Stolee via GitGitGadget 2020-09-08 13:07 ` Đoàn Trần Công Danh 2020-09-09 12:14 ` Derrick Stolee 2020-09-04 15:42 ` [PATCH 3/7] for-each-repo: run subcommands on configured repos Derrick Stolee via GitGitGadget 2020-09-04 15:42 ` [PATCH 4/7] maintenance: add [un]register subcommands Derrick Stolee via GitGitGadget 2020-09-04 15:42 ` [PATCH 5/7] maintenance: add start/stop subcommands Derrick Stolee via GitGitGadget 2020-09-08 6:29 ` SZEDER Gábor 2020-09-08 12:43 ` Derrick Stolee 2020-09-08 19:31 ` Junio C Hamano 2020-09-04 15:42 ` [PATCH 6/7] maintenance: recommended schedule in register/start Derrick Stolee via GitGitGadget 2020-09-04 15:42 ` [PATCH 7/7] maintenance: add troubleshooting guide to docs Derrick Stolee via GitGitGadget 2020-09-11 17:49 ` [PATCH v2 0/7] Maintenance III: Background maintenance Derrick Stolee via GitGitGadget 2020-09-11 17:49 ` [PATCH v2 1/7] maintenance: optionally skip --auto process Derrick Stolee via GitGitGadget 2020-09-11 17:49 ` [PATCH v2 2/7] maintenance: add --schedule option and config Derrick Stolee via GitGitGadget 2020-09-11 17:49 ` [PATCH v2 3/7] for-each-repo: run subcommands on configured repos Derrick Stolee via GitGitGadget 2020-09-11 17:49 ` [PATCH v2 4/7] maintenance: add [un]register subcommands Derrick Stolee via GitGitGadget 2020-09-17 14:05 ` Đoàn Trần Công Danh 2020-09-11 17:49 ` [PATCH v2 5/7] maintenance: add start/stop subcommands Derrick Stolee via GitGitGadget 2020-09-11 17:49 ` [PATCH v2 6/7] maintenance: recommended schedule in register/start Derrick Stolee via GitGitGadget 2020-09-29 19:48 ` Martin Ågren 2020-09-30 20:11 ` Derrick Stolee [this message] 2020-10-01 20:38 ` Derrick Stolee 2020-10-02 0:38 ` Đoàn Trần Công Danh 2020-10-02 1:55 ` Derrick Stolee 2020-10-05 13:16 ` Đoàn Trần Công Danh 2020-10-05 18:17 ` Derrick Stolee 2020-09-11 17:49 ` [PATCH v2 7/7] maintenance: add troubleshooting guide to docs Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 0/7] Maintenance III: Background maintenance Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 1/7] maintenance: optionally skip --auto process Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 2/7] maintenance: add --schedule option and config Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 3/7] for-each-repo: run subcommands on configured repos Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 4/7] maintenance: add [un]register subcommands Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 5/7] maintenance: add start/stop subcommands Derrick Stolee via GitGitGadget 2020-10-05 12:57 ` [PATCH v3 6/7] maintenance: use default schedule if not configured Derrick Stolee via GitGitGadget 2020-10-05 19:57 ` Martin Ågren 2020-10-08 13:32 ` Derrick Stolee 2020-10-05 12:57 ` [PATCH v3 7/7] maintenance: add troubleshooting guide to docs Derrick Stolee via GitGitGadget 2020-10-15 17:21 ` [PATCH v4 0/8] Maintenance III: Background maintenance Derrick Stolee via GitGitGadget 2020-10-15 17:21 ` [PATCH v4 1/8] maintenance: optionally skip --auto process Derrick Stolee via GitGitGadget 2020-10-15 17:21 ` [PATCH v4 2/8] maintenance: add --schedule option and config Derrick Stolee via GitGitGadget 2021-02-09 14:06 ` Ævar Arnfjörð Bjarmason 2021-02-09 16:54 ` Derrick Stolee 2021-05-10 12:16 ` Ævar Arnfjörð Bjarmason 2021-05-10 18:42 ` Junio C Hamano 2020-10-15 17:21 ` [PATCH v4 3/8] for-each-repo: run subcommands on configured repos Derrick Stolee via GitGitGadget 2021-05-03 16:10 ` Andrzej Hunt 2021-05-03 17:01 ` Eric Sunshine 2021-05-03 19:26 ` Eric Sunshine 2021-05-03 19:43 ` Derrick Stolee 2020-10-15 17:22 ` [PATCH v4 4/8] maintenance: add [un]register subcommands Derrick Stolee via GitGitGadget 2020-10-15 17:22 ` [PATCH v4 5/8] maintenance: add start/stop subcommands Derrick Stolee via GitGitGadget 2020-12-09 18:51 ` Josh Steadmon 2020-12-09 19:16 ` Josh Steadmon 2020-12-09 21:59 ` Derrick Stolee 2020-12-10 0:13 ` Junio C Hamano 2020-12-10 1:52 ` Derrick Stolee 2020-12-10 6:54 ` Junio C Hamano 2020-10-15 17:22 ` [PATCH v4 6/8] maintenance: create maintenance.strategy config Derrick Stolee via GitGitGadget 2020-10-15 17:22 ` [PATCH v4 7/8] maintenance: use 'incremental' strategy by default Derrick Stolee via GitGitGadget 2020-10-15 17:22 ` [PATCH v4 8/8] maintenance: add troubleshooting guide to docs Derrick Stolee via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bb9cd08f-1e59-ae19-b184-545688451203@gmail.com \ --to=stolee@gmail.com \ --cc=congdanhqx@gmail.com \ --cc=derrickstolee@github.com \ --cc=dstolee@microsoft.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=jonathantanmy@google.com \ --cc=jrnieder@gmail.com \ --cc=martin.agren@gmail.com \ --cc=sluongng@gmail.com \ --cc=szeder.dev@gmail.com \ --subject='Re: [PATCH v2 6/7] maintenance: recommended schedule in register/start' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).