git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Derrick Stolee <dstolee@microsoft.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning
Date: Tue, 29 May 2018 20:57:54 -0400	[thread overview]
Message-ID: <ba3b8e06-b5e1-99a1-0fe4-ff97d6da8f15@gmail.com> (raw)
In-Reply-To: <b22d20c2-f084-1727-cb98-06707e874ef1@ramsayjones.plus.com>

n 5/29/2018 4:01 PM, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f),
> could you please squash this into the relevant patch (commit 80453b4529,
> "commit-graph: add 'verify' subcommand", 2018-05-24).
>
> [No, No, that was the one in graph_read(). :-D ]

Thanks for helping rid me of my bad habits! I'll get this one in v4.

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>   builtin/commit-graph.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
> index 20ce6437a..6abfde5e6 100644
> --- a/builtin/commit-graph.c
> +++ b/builtin/commit-graph.c
> @@ -39,7 +39,7 @@ static struct opts_commit_graph {
>   
>   static int graph_verify(int argc, const char **argv)
>   {
> -	struct commit_graph *graph = 0;
> +	struct commit_graph *graph = NULL;
>   	char *graph_name;
>   
>   	static struct option builtin_commit_graph_verify_options[] = {

      reply	other threads:[~2018-05-30  0:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 20:01 [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning Ramsay Jones
2018-05-30  0:57 ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba3b8e06-b5e1-99a1-0fe4-ff97d6da8f15@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).