* [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning
@ 2018-05-29 20:01 Ramsay Jones
2018-05-30 0:57 ` Derrick Stolee
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2018-05-29 20:01 UTC (permalink / raw)
To: Derrick Stolee; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Derrick,
If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f),
could you please squash this into the relevant patch (commit 80453b4529,
"commit-graph: add 'verify' subcommand", 2018-05-24).
[No, No, that was the one in graph_read(). :-D ]
Thanks!
ATB,
Ramsay Jones
builtin/commit-graph.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 20ce6437a..6abfde5e6 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -39,7 +39,7 @@ static struct opts_commit_graph {
static int graph_verify(int argc, const char **argv)
{
- struct commit_graph *graph = 0;
+ struct commit_graph *graph = NULL;
char *graph_name;
static struct option builtin_commit_graph_verify_options[] = {
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning
2018-05-29 20:01 [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning Ramsay Jones
@ 2018-05-30 0:57 ` Derrick Stolee
0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2018-05-30 0:57 UTC (permalink / raw)
To: Ramsay Jones, Derrick Stolee; +Cc: Junio C Hamano, GIT Mailing-list
n 5/29/2018 4:01 PM, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f),
> could you please squash this into the relevant patch (commit 80453b4529,
> "commit-graph: add 'verify' subcommand", 2018-05-24).
>
> [No, No, that was the one in graph_read(). :-D ]
Thanks for helping rid me of my bad habits! I'll get this one in v4.
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> builtin/commit-graph.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
> index 20ce6437a..6abfde5e6 100644
> --- a/builtin/commit-graph.c
> +++ b/builtin/commit-graph.c
> @@ -39,7 +39,7 @@ static struct opts_commit_graph {
>
> static int graph_verify(int argc, const char **argv)
> {
> - struct commit_graph *graph = 0;
> + struct commit_graph *graph = NULL;
> char *graph_name;
>
> static struct option builtin_commit_graph_verify_options[] = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-30 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29 20:01 [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning Ramsay Jones
2018-05-30 0:57 ` Derrick Stolee
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).