git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philip Oakley <philipoakley@iee.email>
To: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>,
	git@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] making --set-upstream have default arguments
Date: Fri, 3 Dec 2021 11:32:25 +0000	[thread overview]
Message-ID: <b9bfd60b-9e4e-caa6-9836-e0f0e984a997@iee.email> (raw)
In-Reply-To: <20211202144354.17416-1-chakrabortyabhradeep79@gmail.com>

On 02/12/2021 14:43, Abhradeep Chakraborty wrote:
> To track a upstream branch from a local branch we need to pass
> <repository> and <refspec> to --set-upstream (in case of git push)
> or to --set-upstream-to (in case of git branch). In most cases,
> users track the upstream branch with the same name as the local
> branch they are currently on. For example, users most of the time
> do 'git push <repository> <current_branch_refspec>'.
>
> So, it would be great if 'git push -u' by default do this. This
> patch series address this. The patches of this patch-set set
> some default values for <repository> and <refspec> if they are
> not given. It first tries to get the value of <repository> from
> 'branch.<current_branch>.remote'. If not then it will set the
> value of <repository> as 'origin'. <refspec>'s value would be
> the short name of the current branch.

Can we protect the expectations of a user with a `pushDefault` setting?
If the user has one set, then the upstream won't be where they push in a
triangular repo workflow.

Philip
>
> The first patch implements it for push command. However, before
> moving to the 'git branch' part, it would be great to have
> discussions about the proposed changes in this patch and whether
> the current changes are the best way to address it or not.
>
> Abhradeep Chakraborty (1):
>   push: make '-u' have default arguments
>
>  Documentation/git-push.txt |  6 +++++
>  builtin/push.c             | 48 ++++++++++++++++++++++++++++----------
>  t/t5523-push-upstream.sh   | 11 +++++++++
>  3 files changed, 53 insertions(+), 12 deletions(-)
>


  parent reply	other threads:[~2021-12-03 11:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 14:43 [RFC PATCH 0/1] making --set-upstream have default arguments Abhradeep Chakraborty
2021-12-02 14:43 ` [RFC PATCH 1/1] push: make '-u' " Abhradeep Chakraborty
2021-12-02 18:24   ` Junio C Hamano
2021-12-03  8:14     ` Abhradeep Chakraborty
2021-12-03 17:29       ` Junio C Hamano
2021-12-03 19:27         ` Abhradeep Chakraborty
2021-12-03 11:32 ` Philip Oakley [this message]
2021-12-03 16:03   ` [RFC PATCH 0/1] making --set-upstream " Abhradeep Chakraborty
2021-12-03 16:46     ` Philip Oakley
2021-12-03 17:28   ` Abhradeep Chakraborty
2021-12-07 18:22 ` [PATCH v2 " Abhradeep Chakraborty
2021-12-07 18:23   ` [PATCH v2 1/1] push: make '-u' " Abhradeep Chakraborty
2021-12-07 22:14     ` Eric Sunshine
2021-12-08  6:12       ` [PATCH v2 1/1] push: make '-u' have default argument Abhradeep Chakraborty
2021-12-09 10:15   ` [PATCH v3 0/1] making --set-upstream have default arguments Abhradeep Chakraborty
2021-12-09 10:15     ` [PATCH v3 1/1] push: make '-u' " Abhradeep Chakraborty
2022-01-01 14:37     ` [PATCH v4 0/1] making --set-upstream " Abhradeep Chakraborty
2022-01-01 14:37       ` [PATCH v4 1/1] push: make 'set-upstream' have dafault arguments Abhradeep Chakraborty
2022-01-04  3:46         ` Junio C Hamano
2022-01-04 13:28           ` Abhradeep Chakraborty
2022-01-04 20:35             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9bfd60b-9e4e-caa6-9836-e0f0e984a997@iee.email \
    --to=philipoakley@iee.email \
    --cc=chakrabortyabhradeep79@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).