From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org,
Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Subject: Re: [PATCH v2 1/1] push: make '-u' have default argument
Date: Wed, 8 Dec 2021 11:42:21 +0530 [thread overview]
Message-ID: <20211208061221.133-1-chakrabortyabhradeep79@gmail.com> (raw)
In-Reply-To: <CAPig+cRxU=pT-qCp-xpHcoae45oxz1d-eRh+QF-SJFM3B-6KyQ@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> wrote:
> As above, because calls to this function are part of the &&-chain in
> test bodies, it is important for the &&-chain to be intact in the
> function too. It's especially important in this case since this
> function is actually checking for specific conditions. As it's
> currently written -- with a broken &&-chain -- if the first
> test_expect_code() fails, we'll never know about it since that exit
> code gets lost; only the exit code from the second test_expect_code()
> has any bearing on the overall result of the test.
Thanks so much for all the suggestions! I am little beginner in shell
scripting. It would help me a lot!
> s/messagesdo/messages do/
oops :|
> The captured stdout in `out` doesn't seem to be used, so it's probably
> better to drop that redirection.
okay.
next prev parent reply other threads:[~2021-12-08 6:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 14:43 [RFC PATCH 0/1] making --set-upstream have default arguments Abhradeep Chakraborty
2021-12-02 14:43 ` [RFC PATCH 1/1] push: make '-u' " Abhradeep Chakraborty
2021-12-02 18:24 ` Junio C Hamano
2021-12-03 8:14 ` Abhradeep Chakraborty
2021-12-03 17:29 ` Junio C Hamano
2021-12-03 19:27 ` Abhradeep Chakraborty
2021-12-03 11:32 ` [RFC PATCH 0/1] making --set-upstream " Philip Oakley
2021-12-03 16:03 ` Abhradeep Chakraborty
2021-12-03 16:46 ` Philip Oakley
2021-12-03 17:28 ` Abhradeep Chakraborty
2021-12-07 18:22 ` [PATCH v2 " Abhradeep Chakraborty
2021-12-07 18:23 ` [PATCH v2 1/1] push: make '-u' " Abhradeep Chakraborty
2021-12-07 22:14 ` Eric Sunshine
2021-12-08 6:12 ` Abhradeep Chakraborty [this message]
2021-12-09 10:15 ` [PATCH v3 0/1] making --set-upstream " Abhradeep Chakraborty
2021-12-09 10:15 ` [PATCH v3 1/1] push: make '-u' " Abhradeep Chakraborty
2022-01-01 14:37 ` [PATCH v4 0/1] making --set-upstream " Abhradeep Chakraborty
2022-01-01 14:37 ` [PATCH v4 1/1] push: make 'set-upstream' have dafault arguments Abhradeep Chakraborty
2022-01-04 3:46 ` Junio C Hamano
2022-01-04 13:28 ` Abhradeep Chakraborty
2022-01-04 20:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208061221.133-1-chakrabortyabhradeep79@gmail.com \
--to=chakrabortyabhradeep79@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).